Bug 90757 - BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized.
Summary: BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 90375 90935
  Show dependency tree / graph
 
Reported: 2012-07-08 23:59 PDT by Dongseong Hwang
Modified: 2012-07-11 14:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2012-07-09 01:04 PDT, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-07-08 23:59:51 PDT 
The current code fortunately has worked so far because only BitmapImage::startAnimation calls frameIsCompleteAtIndex, and startAnimation cannot call frameIsCompleteAtIndex if ImageDecoder is not yet initialized. startAnimation returns at the first line becase shouldAnimate() always return false in this case.

        if (m_frameTimer || !shouldAnimate() || frameCount() <= 1)
            return;

This change is needed because parallel image decoders call BitmapImage::frameIsCompleteAtIndex in other places too.
Comment 1 Dongseong Hwang 2012-07-09 01:04:18 PDT 
Created attachment 151205 [details]
Patch
Comment 2 Kwang Yul Seo 2012-07-11 14:03:58 PDT 
Comment on attachment 151205 [details]
Patch

Clearing flags on attachment: 151205

Committed r122368: <http://trac.webkit.org/changeset/122368>
Comment 3 Kwang Yul Seo 2012-07-11 14:04:04 PDT 
All reviewed patches have been landed.  Closing bug.