Bug 90869 - Add ImageDecodeWorker
Summary: Add ImageDecodeWorker
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 90780
Blocks: 90375 90935
  Show dependency tree / graph
 
Reported: 2012-07-10 04:27 PDT by Kwang Yul Seo
Modified: 2012-08-06 22:22 PDT (History)
10 users (show)

See Also:

Attachments
Patch (17.45 KB, patch)
2012-07-11 02:21 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.49 KB, patch)
2012-07-11 03:28 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.49 KB, patch)
2012-07-11 03:31 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.58 KB, patch)
2012-07-11 22:15 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.67 KB, patch)
2012-07-11 23:01 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.67 KB, patch)
2012-07-12 00:37 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (18.20 KB, patch)
2012-07-16 21:51 PDT, Kwonjin Jeong 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-07-10 04:27:59 PDT 
ImageDecodeWorker is a thread pool implementation based on WorkQueue. ImageDecodeWorker internally manages a pool of WorkQueues (n = number of cores) and assigns one from the pool when an ImageDecodeWorker instance is created. So two ImageDecodeWorkers can share one WorkQueue.

Parallel image decoders create an instance of ImageDecodeWorker for each image. So the number of ImageDecodeWorker instances can be arbitrarily large, but the number of WorkQueues is limited to the number of cores. This effectively utilizes the underlying cores.
Comment 1 Kwonjin Jeong 2012-07-11 02:21:36 PDT 
Created attachment 151656 [details]
Patch
Comment 2 Build Bot 2012-07-11 02:30:56 PDT 
Comment on attachment 151656 [details]
Patch

Attachment 151656 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13204301
Comment 3 Build Bot 2012-07-11 02:44:32 PDT 
Comment on attachment 151656 [details]
Patch

Attachment 151656 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13207234
Comment 4 Gyuyoung Kim 2012-07-11 02:47:42 PDT 
Comment on attachment 151656 [details]
Patch

Attachment 151656 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13202279
Comment 5 Kwang Yul Seo 2012-07-11 03:10:55 PDT 
Please don't run ews because this patch doesn't build until Bug 90780 is landed.
Comment 6 Early Warning System Bot 2012-07-11 03:27:40 PDT 
Comment on attachment 151656 [details]
Patch

Attachment 151656 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13199252
Comment 7 Early Warning System Bot 2012-07-11 03:28:38 PDT 
Comment on attachment 151656 [details]
Patch

Attachment 151656 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13205285
Comment 8 Kwonjin Jeong 2012-07-11 03:28:47 PDT 
Created attachment 151666 [details]
Patch
Comment 9 Kwonjin Jeong 2012-07-11 03:31:40 PDT 
Created attachment 151667 [details]
Patch
Comment 10 WebKit Review Bot 2012-07-11 03:36:19 PDT 
Comment on attachment 151667 [details]
Patch

Attachment 151667 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13204311
Comment 11 Build Bot 2012-07-11 03:36:31 PDT 
Comment on attachment 151667 [details]
Patch

Attachment 151667 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13198317
Comment 12 Gyuyoung Kim 2012-07-11 03:43:43 PDT 
Comment on attachment 151667 [details]
Patch

Attachment 151667 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13209311
Comment 13 Build Bot 2012-07-11 03:54:07 PDT 
Comment on attachment 151667 [details]
Patch

Attachment 151667 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13219019
Comment 14 Early Warning System Bot 2012-07-11 04:46:45 PDT 
Comment on attachment 151667 [details]
Patch

Attachment 151667 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13214021
Comment 15 Early Warning System Bot 2012-07-11 04:50:22 PDT 
Comment on attachment 151667 [details]
Patch

Attachment 151667 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13206310
Comment 16 Kwonjin Jeong 2012-07-11 22:15:00 PDT 
Created attachment 151857 [details]
Patch
Comment 17 WebKit Review Bot 2012-07-11 22:21:11 PDT 
Comment on attachment 151857 [details]
Patch

Attachment 151857 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13203593
Comment 18 Build Bot 2012-07-11 22:30:41 PDT 
Comment on attachment 151857 [details]
Patch

Attachment 151857 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13180691
Comment 19 Early Warning System Bot 2012-07-11 22:34:03 PDT 
Comment on attachment 151857 [details]
Patch

Attachment 151857 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13207521
Comment 20 Early Warning System Bot 2012-07-11 22:40:08 PDT 
Comment on attachment 151857 [details]
Patch

Attachment 151857 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13206580
Comment 21 Gyuyoung Kim 2012-07-11 22:47:23 PDT 
Comment on attachment 151857 [details]
Patch

Attachment 151857 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13198642
Comment 22 Kwonjin Jeong 2012-07-11 23:01:47 PDT 
Created attachment 151866 [details]
Patch
Comment 23 Kwonjin Jeong 2012-07-12 00:37:35 PDT 
Created attachment 151872 [details]
Patch
Comment 24 Kwonjin Jeong 2012-07-16 21:51:05 PDT 
Created attachment 152695 [details]
Patch
Comment 25 Kwang Yul Seo 2012-07-17 18:47:19 PDT 
This patch will break cr-linux build because Chromium port does not have WorkQueue implementation.
Comment 26 WebKit Review Bot 2012-07-17 19:06:12 PDT 
Comment on attachment 152695 [details]
Patch

Attachment 152695 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13281359
Comment 27 Gustavo Noronha (kov) 2012-07-17 19:07:31 PDT 
Comment on attachment 152695 [details]
Patch

Attachment 152695 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13279359
Comment 28 Gyuyoung Kim 2012-07-17 19:07:37 PDT 
Comment on attachment 152695 [details]
Patch

Attachment 152695 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13272333
Comment 29 Build Bot 2012-07-17 19:25:15 PDT 
Comment on attachment 152695 [details]
Patch

Attachment 152695 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13276335
Comment 30 Early Warning System Bot 2012-07-17 19:38:59 PDT 
Comment on attachment 152695 [details]
Patch

Attachment 152695 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13284329
Comment 31 Early Warning System Bot 2012-07-17 19:39:56 PDT 
Comment on attachment 152695 [details]
Patch

Attachment 152695 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13284330
Comment 32 Build Bot 2012-07-17 23:20:59 PDT 
Comment on attachment 152695 [details]
Patch

Attachment 152695 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13276385
Comment 33 Kwang Yul Seo 2012-08-06 22:22:19 PDT 
We are working on 90869 instead. Close this bug as WONTFIX.