Bug 90780 - Move WorkQueue to WTF
Summary: Move WorkQueue to WTF
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on:
Blocks: 90375 90869
  Show dependency tree / graph
 
Reported: 2012-07-09 05:27 PDT by Kwang Yul Seo
Modified: 2012-08-09 16:52 PDT (History)
8 users (show)

See Also:

Attachments
Patch (125.10 KB, patch)
2012-07-09 05:44 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Patch (126.60 KB, patch)
2012-07-09 05:58 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Patch (126.56 KB, patch)
2012-07-09 06:00 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Patch (126.72 KB, patch)
2012-07-09 06:03 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Patch (129.15 KB, patch)
2012-07-11 00:51 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (131.80 KB, patch)
2012-07-11 01:32 PDT, Kwonjin Jeong 		no flags Details | Formatted Diff | Diff
Patch (126.77 KB, patch)
2012-07-25 18:25 PDT, Kwonjin Jeong 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-07-09 05:27:10 PDT 
Currently, WorkQueue is in WebKit2. By moving WorkQueue and PlatformProcessIdentifier to WTF, WebCore code can use it. 

This patch is required for parallel image decoders because WorkQueue is used to make image decoding off the main thread.
Comment 1 Kwang Yul Seo 2012-07-09 05:44:00 PDT 
Created attachment 151238 [details]
Patch
Comment 2 Build Bot 2012-07-09 05:49:37 PDT 
Comment on attachment 151238 [details]
Patch

Attachment 151238 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13157819
Comment 3 Early Warning System Bot 2012-07-09 05:49:54 PDT 
Comment on attachment 151238 [details]
Patch

Attachment 151238 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13162259
Comment 4 Kwang Yul Seo 2012-07-09 05:58:18 PDT 
Created attachment 151240 [details]
Patch
Comment 5 Kwang Yul Seo 2012-07-09 06:00:04 PDT 
Created attachment 151241 [details]
Patch
Comment 6 Kwang Yul Seo 2012-07-09 06:03:28 PDT 
Created attachment 151242 [details]
Patch
Comment 7 Build Bot 2012-07-09 06:24:38 PDT 
Comment on attachment 151242 [details]
Patch

Attachment 151242 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13157829
Comment 8 Kwang Yul Seo 2012-07-09 07:10:58 PDT 
I will fix the build soon ;(
Comment 9 Build Bot 2012-07-09 09:00:27 PDT 
Comment on attachment 151242 [details]
Patch

Attachment 151242 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13164293
Comment 10 Kwonjin Jeong 2012-07-11 00:51:09 PDT 
Created attachment 151627 [details]
Patch
Comment 11 Zoltan Horvath 2012-07-11 00:56:06 PDT 
It's another task, but later it would be nice to merge ParallelJobs (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/ParallelJobs.h) and the moved WorkQueue.
Comment 12 Kwang Yul Seo 2012-07-11 00:57:47 PDT 
(In reply to comment #10)
> Created an attachment (id=151627) [details]
> Patch

Thanks for build fix!
Comment 13 Kwang Yul Seo 2012-07-11 01:05:04 PDT 
(In reply to comment #11)
> It's another task, but later it would be nice to merge ParallelJobs (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/ParallelJobs.h) and the moved WorkQueue.

Isn't ParallelJobs for data parallelism? How can they be merged?
Comment 14 Build Bot 2012-07-11 01:17:17 PDT 
Comment on attachment 151627 [details]
Patch

Attachment 151627 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13166727
Comment 15 Kwonjin Jeong 2012-07-11 01:32:41 PDT 
Created attachment 151643 [details]
Patch
Comment 16 Kwang Yul Seo 2012-07-11 02:18:17 PDT 
I think we can improve WorkQueue later to satisfy the requirements of ThreadCommunication ( https://trac.webkit.org/wiki/ThreadCommunication ).

CC'ing Levin for further discussion.
Comment 17 Kwonjin Jeong 2012-07-25 18:25:22 PDT 
Created attachment 154508 [details]
Patch
Comment 18 Build Bot 2012-07-26 14:21:19 PDT 
Comment on attachment 154508 [details]
Patch

Attachment 154508 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13368055
Comment 19 Kwang Yul Seo 2012-08-06 22:22:02 PDT 
We are working on 90869 instead. Close this bug as WONTFIX.