Bug 90601 – [WK2][EFL] Ewk_View should provide more resource loading notifications

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

Basic resource loading notifications such as:
- Resource request sent
- Resource request failed
- Resource request finished

are not currently supported by Ewk_View. We need to implement this.

[Chris Dumez]

Created attachment 150925 [details]
Patch

I'll need to update the patch after Bug 90566 lands. I need to clear the resource HashMap when the main frame provisional load starts. However, the "provisional load started" callback is introduced in Bug 90566.

[Gyuyoung Kim]

Comment on attachment 150925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150925&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:155
> +    Ewk_Url_Response *redirectResponse; /**< Possible redirect response for the resource */

s/redirectResponse/redirect_response/g

[Chris Dumez]

Created attachment 151022 [details]
Patch

Take Gyuyoung's feedback into consideration and rebase on master now that the dependency landed.

[Chris Dumez]

Created attachment 151609 [details]
Patch

Rebase on master.

[Gyuyoung Kim]

Comment on attachment 151609 [details]
Patch

Attachment 151609 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13180322

[Chris Dumez]

Created attachment 151611 [details]
Patch

[Chris Dumez]

Created attachment 151736 [details]
Patch

Rebase on master.

[Chris Dumez]

Created attachment 151744 [details]
Patch

[Chris Dumez]

Rakuco, can you please double-check and cq?

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 151744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151744&action=review

Looks mostly OK to me. I'm cq+'ing it, and we can discuss details later. I think we talked about this a few months ago -- wouldn't it make sense to initialize `url' and `mimeType' in ewk_url_response_new and avoid the casts in ewk_url_response_{mime_type,url_}_get()?

> Source/WebKit2/UIProcess/API/efl/ewk_url_response.h:53
> + * When the reference count it's reached 0, the URL request is freed.

Nit: s/it's reached/reaches/.

[WebKit Review Bot]

Comment on attachment 151744 [details]
Patch

Clearing flags on attachment: 151744

Committed r122411: <http://trac.webkit.org/changeset/122411>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.