Bug 90601 - [WK2][EFL] Ewk_View should provide more resource loading notifications
Summary: [WK2][EFL] Ewk_View should provide more resource loading notifications
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 90566
Blocks: 61838
  Show dependency treegraph
 
Reported: 2012-07-05 04:24 PDT by Chris Dumez
Modified: 2012-07-11 20:22 PDT (History)
7 users (show)

See Also:


Attachments
Patch (24.83 KB, patch)
2012-07-05 05:11 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (25.63 KB, patch)
2012-07-05 23:20 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (25.31 KB, patch)
2012-07-10 23:26 PDT, Chris Dumez
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (25.34 KB, patch)
2012-07-10 23:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (26.09 KB, patch)
2012-07-11 11:15 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (26.09 KB, patch)
2012-07-11 11:56 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-05 04:24:14 PDT
Basic resource loading notifications such as:
- Resource request sent
- Resource request failed
- Resource request finished

are not currently supported by Ewk_View. We need to implement this.
Comment 1 Chris Dumez 2012-07-05 05:11:03 PDT
Created attachment 150925 [details]
Patch

I'll need to update the patch after Bug 90566 lands. I need to clear the resource HashMap when the main frame provisional load starts. However, the "provisional load started" callback is introduced in Bug 90566.
Comment 2 Gyuyoung Kim 2012-07-05 19:37:10 PDT
Comment on attachment 150925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150925&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:155
> +    Ewk_Url_Response *redirectResponse; /**< Possible redirect response for the resource */

s/redirectResponse/redirect_response/g
Comment 3 Chris Dumez 2012-07-05 23:20:34 PDT
Created attachment 151022 [details]
Patch

Take Gyuyoung's feedback into consideration and rebase on master now that the dependency landed.
Comment 4 Chris Dumez 2012-07-10 23:26:23 PDT
Created attachment 151609 [details]
Patch

Rebase on master.
Comment 5 Gyuyoung Kim 2012-07-10 23:31:16 PDT
Comment on attachment 151609 [details]
Patch

Attachment 151609 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13180322
Comment 6 Chris Dumez 2012-07-10 23:33:48 PDT
Created attachment 151611 [details]
Patch
Comment 7 Chris Dumez 2012-07-11 11:15:05 PDT
Created attachment 151736 [details]
Patch

Rebase on master.
Comment 8 Chris Dumez 2012-07-11 11:56:46 PDT
Created attachment 151744 [details]
Patch
Comment 9 Chris Dumez 2012-07-11 13:31:28 PDT
Rakuco, can you please double-check and cq?
Comment 10 Raphael Kubo da Costa (:rakuco) 2012-07-11 19:13:11 PDT
Comment on attachment 151744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151744&action=review

Looks mostly OK to me. I'm cq+'ing it, and we can discuss details later. I think we talked about this a few months ago -- wouldn't it make sense to initialize `url' and `mimeType' in ewk_url_response_new and avoid the casts in ewk_url_response_{mime_type,url_}_get()?

> Source/WebKit2/UIProcess/API/efl/ewk_url_response.h:53
> + * When the reference count it's reached 0, the URL request is freed.

Nit: s/it's reached/reaches/.
Comment 11 WebKit Review Bot 2012-07-11 20:22:18 PDT
Comment on attachment 151744 [details]
Patch

Clearing flags on attachment: 151744

Committed r122411: <http://trac.webkit.org/changeset/122411>
Comment 12 WebKit Review Bot 2012-07-11 20:22:23 PDT
All reviewed patches have been landed.  Closing bug.