Bug 90566 – [WK2][EFL] Ewk_View needs to report load status changes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

The Ewk_View does not currently report:
- Load finished
- Provisional load started
- Provisional load redirect
- Provisional load failed

We need the emit signals to notify the client of each load status change.

[Chris Dumez]

Created attachment 150818 [details]
Patch

[Chris Dumez]

Created attachment 150905 [details]
Patch

Rebase on master.

[Kenneth Rohde Christiansen]

Comment on attachment 150905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150905&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:37
>   * - "load,error", const Ewk_Web_Error*: reports main frame load failed.
> + * - "load,finished", void: reports load finished.
>   * - "load,progress", double*: load progress has changed (value from 0.0 to 1.0).
> + * - "load,provisional,failed", const Ewk_Web_Error*: view provisional load failed.
> + * - "load,provisional,redirect", void: view received redirect for provisional load.
> + * - "load,provisional,started", void: view started provisional load.
>   * - "resource,request,new", const Ewk_Web_Resource_Request*: a resource request was initiated.

Why do you need to mark that it is provisional? and if you get load,provisional,failed will that then be followed by load,failed?

[Chris Dumez]

(In reply to comment #3)
> (From update of attachment 150905 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=150905&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:37
> >   * - "load,error", const Ewk_Web_Error*: reports main frame load failed.
> > + * - "load,finished", void: reports load finished.
> >   * - "load,progress", double*: load progress has changed (value from 0.0 to 1.0).
> > + * - "load,provisional,failed", const Ewk_Web_Error*: view provisional load failed.
> > + * - "load,provisional,redirect", void: view received redirect for provisional load.
> > + * - "load,provisional,started", void: view started provisional load.
> >   * - "resource,request,new", const Ewk_Web_Resource_Request*: a resource request was initiated.
> 
> Why do you need to mark that it is provisional? and if you get load,provisional,failed will that then be followed by load,failed?

Actually, in WebKit1-EFL, we were emitting both signals "load,provisional,failed" and then "load,error" if the provisional load failed. Should we do the same thing for WebKit2-EFL? I know that Qt uses a single signal for those 2 events but this prevents the client from making the distinction if it wants to. For example, in DRT, we had to make the distinction to print the proper output.
I checked GTK port as well and while they use a single signal, they have an additional "provisional" / "committed" parameter so that they can be distinguished. As you know, adding a new parameter to an EFL signal is not very convenient or nice, and I would rather use separate signals.

[Chris Dumez]

Ok, so no "load,error" signal after the "load,provisional,failed" then?

[WebKit Review Bot]

Comment on attachment 150905 [details]
Patch

Clearing flags on attachment: 150905

Committed r121944: <http://trac.webkit.org/changeset/121944>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.