nrwt: preliminary cleanup before supporting cascading expectations files
Created attachment 147212 [details] Patch
Comment on attachment 147212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147212&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:239 > + expectation_line.filename = '<Skipped file>' Should this have a FIXME to associate paths with Skipped file lines as well? I doubt we'll ever get around to it as we'll hopefully drop Skipped files entirely.
(In reply to comment #2) > (From update of attachment 147212 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147212&action=review > > > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:239 > > + expectation_line.filename = '<Skipped file>' > > Should this have a FIXME to associate paths with Skipped file lines as well? I doubt we'll ever get around to it as we'll hopefully drop Skipped files entirely. Two observations: the first is that some skipped entries are actually runtime-computed and don't actually live in files (some come from the command line as well). The second is that I'm planning to move the Skipped files to TestExpectations files (unless someone objects) and then, as you say, it'll go away. I'll add a comment, though.
Committed r120230: <http://trac.webkit.org/changeset/120230>
whoops, forgot the fixme ... will add it in the next patch.