Bug 88944 - nrwt: restructure the port classes to handle multiple expectations files
Summary: nrwt: restructure the port classes to handle multiple expectations files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 88942
Blocks: 65834 88946
  Show dependency tree / graph
 
Reported: 2012-06-12 19:21 PDT by Dirk Pranke
Modified: 2012-06-13 12:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (23.58 KB, patch)
2012-06-12 19:26 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-06-12 19:21:17 PDT 
nrwt: restructure the port classes to handle multiple expectations files
Comment 1 Dirk Pranke 2012-06-12 19:26:36 PDT 
Created attachment 147215 [details]
Patch
Comment 2 Ojan Vafai 2012-06-13 09:30:05 PDT 
Comment on attachment 147215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147215&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:924
> +    def test_expectations(self):

Add a FIXME to remove this?

> Tools/Scripts/webkitpy/layout_tests/port/base.py:931
>      def test_expectations_overrides(self):

Add a FIXME to remove this?
Comment 3 Dirk Pranke 2012-06-13 10:19:34 PDT 
Will do. Obviously, they get removed later in this series of patches, but better to be safe in the meantime.
Comment 4 Dirk Pranke 2012-06-13 12:40:59 PDT 
Committed r120236: <http://trac.webkit.org/changeset/120236>