Bug 88913 - [Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-matching.html fails
Summary: [Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-match...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pablo Flouret
Keywords: Qt, QtTriaged
Depends on:
Blocks: 79666 88896
  Show dependency treegraph
Reported: 2012-06-12 13:57 PDT by Csaba Osztrogonác
Modified: 2012-10-09 21:55 PDT (History)
3 users (show)

See Also:

Patch (2.98 KB, patch)
2012-10-09 14:35 PDT, Pablo Flouret
ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-06-12 13:57:07 PDT
r120107 made http/tests/xmlhttprequest/origin-exact-matching.html fail on Qt. 

See http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r120107%20%2838626%29/http/tests/xmlhttprequest/origin-exact-matching-pretty-diff.html for details.

Could you check it, please?
Comment 1 Csaba Osztrogonác 2012-06-12 14:57:15 PDT
I skipped it on Qt to paint the bot green. (r120126) Please unskip it with the proper fix.
Comment 2 Pablo Flouret 2012-06-12 15:47:53 PDT
The only suspect i can find is this line:

$origin = isset($_GET['origin']) ? $_GET['origin'] : $_SERVER['HTTP_ORIGIN'];

The tests that fail are the ones where the origin starts with a null character. Maybe that's fooling isset() in that platform? *preventively curses php*

I can make a patch to use the origin directly without checking and see if that's the problem. I don't have the ability to build a linux64 qt, is there a way to test if it would work or is landing a patch and looking at what happens the only way to move forward?
Comment 3 Csaba Osztrogonác 2012-10-09 01:11:44 PDT
The bug is still valid now.
Comment 4 Pablo Flouret 2012-10-09 14:35:03 PDT
Created attachment 167849 [details]

Would you mind trying this patch somewhere and checking if the test still fails?
Comment 5 Csaba Osztrogonác 2012-10-09 21:29:16 PDT
Comment on attachment 167849 [details]

It works for me now, r=me. I'll land it manually with unskipping this test.
Comment 6 Csaba Osztrogonác 2012-10-09 21:55:38 PDT
Landed in r130845