Bug 88913 – [Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-matching.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

r120107 made http/tests/xmlhttprequest/origin-exact-matching.html fail on Qt. 

See http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r120107%20%2838626%29/http/tests/xmlhttprequest/origin-exact-matching-pretty-diff.html for details.

Could you check it, please?

[Csaba Osztrogonác]

I skipped it on Qt to paint the bot green. (r120126) Please unskip it with the proper fix.

[Pablo Flouret]

The only suspect i can find is this line:

$origin = isset($_GET['origin']) ? $_GET['origin'] : $_SERVER['HTTP_ORIGIN'];

The tests that fail are the ones where the origin starts with a null character. Maybe that's fooling isset() in that platform? *preventively curses php*

I can make a patch to use the origin directly without checking and see if that's the problem. I don't have the ability to build a linux64 qt, is there a way to test if it would work or is landing a patch and looking at what happens the only way to move forward?

[Csaba Osztrogonác]

The bug is still valid now.

[Pablo Flouret]

Created attachment 167849 [details]
Patch

Would you mind trying this patch somewhere and checking if the test still fails?

[Csaba Osztrogonác]

Comment on attachment 167849 [details]
Patch

It works for me now, r=me. I'll land it manually with unskipping this test.

[Csaba Osztrogonác]

Landed in r130845