Bug 88896 - LayoutTests/http/tests/xmlhttprequest/origin-exact-matching.html is giving trouble due to too many redirects
Summary: LayoutTests/http/tests/xmlhttprequest/origin-exact-matching.html is giving tr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 88139 88913
Blocks: 88727
  Show dependency treegraph
 
Reported: 2012-06-12 11:30 PDT by Pablo Flouret
Modified: 2012-06-12 22:34 PDT (History)
4 users (show)

See Also:


Attachments
Patch (19.12 KB, patch)
2012-06-12 11:37 PDT, Pablo Flouret
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Flouret 2012-06-12 11:30:49 PDT
The test is giving out "too many redirect" errors on GTK and EFL due to using redirect-cors.php without an actual url to redirect.

Redirects are not actually tested in that test, a script that set the Access-Control-Allow-Origin header to an arbitrary origin was needed and redirect-cors.php was the only existing one that had the capability. The infinite redirect thing was an unintended consequence, so a different script should be used to set the header.
Comment 1 Pablo Flouret 2012-06-12 11:37:36 PDT
Created attachment 147123 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-12 13:09:37 PDT
Comment on attachment 147123 [details]
Patch

Clearing flags on attachment: 147123

Committed r120107: <http://trac.webkit.org/changeset/120107>
Comment 3 WebKit Review Bot 2012-06-12 13:09:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Chris Dumez 2012-06-12 22:34:56 PDT
Thanks, this worked. http/tests/xmlhttprequest/origin-exact-matching.html is now passing on EFL bot.