Bug 85838 - [CMake] Add ENABLE_IFRAME_SEAMLESS flag
Summary: [CMake] Add ENABLE_IFRAME_SEAMLESS flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
: 85861 (view as bug list)
Depends on:
Blocks: 85601
  Show dependency tree / graph
 
Reported: 2012-05-07 15:51 PDT by Thiago Marcos P. Santos
Modified: 2012-05-08 10:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2012-05-08 01:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2012-05-08 07:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-05-07 15:51:57 PDT 
Add support for ENABLE_IFRAME_SEAMLESS like it was done in bug 85822.
Comment 1 Thiago Marcos P. Santos 2012-05-07 15:52:42 PDT 
Should be enable by default for EFL, need to check for Win and Blackberry.
Comment 2 Thiago Marcos P. Santos 2012-05-07 23:08:42 PDT 
*** Bug 85861 has been marked as a duplicate of this bug. ***
Comment 3 Chris Dumez 2012-05-07 23:10:22 PDT 
Thiago, it needs to enabled for everything except MAC since the code used to be compiled unconditionally.
Comment 4 Chris Dumez 2012-05-08 01:25:11 PDT 
Created attachment 140688 [details]
Patch
Comment 5 Gyuyoung Kim 2012-05-08 01:30:08 PDT 
Comment on attachment 140688 [details]
Patch

Looks fine on my side.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-05-08 07:14:35 PDT 
The CMake-specific part looks fine, dunno if Eric plans on adding an option to build-webkit, though.
Comment 7 Chris Dumez 2012-05-08 07:26:34 PDT 
Created attachment 140715 [details]
Patch

No longer update the build-webkit script.
Comment 8 Eric Seidel (no email) 2012-05-08 10:50:29 PDT 
Comment on attachment 140715 [details]
Patch

I'll add the build-webkit option when I land the generate-feature-files script, which will hopefully be this week.
Comment 9 Eric Seidel (no email) 2012-05-08 10:50:50 PDT 
You're also welcoem to add a build-webkit option if you like, it should default to on for everyone.
Comment 10 WebKit Review Bot 2012-05-08 10:57:42 PDT 
Comment on attachment 140715 [details]
Patch

Clearing flags on attachment: 140715

Committed r116436: <http://trac.webkit.org/changeset/116436>
Comment 11 WebKit Review Bot 2012-05-08 10:57:48 PDT 
All reviewed patches have been landed.  Closing bug.