Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed
Created attachment 140581 [details] Patch
Comment on attachment 140581 [details] Patch Attachment 140581 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12656101
Comment on attachment 140581 [details] Patch Attachment 140581 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12652130
Comment on attachment 140581 [details] Patch Attachment 140581 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12656104
Comment on attachment 140581 [details] Patch Attachment 140581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12644257
Created attachment 140583 [details] Patch for landing
Yes, this means seamless is off for everyone else after this change, which is less than ideal. I'm working on fixing bug 85456 so we don't have to care about this sort of crap in the future.
Created attachment 140585 [details] Patch for landing
Comment on attachment 140585 [details] Patch for landing Clearing flags on attachment: 140585 Committed r116356: <http://trac.webkit.org/changeset/116356>
All reviewed patches have been landed. Closing bug.
I'm not sure if you meant to enable or disable ENABLE_IFRAME_SEAMLESS by default. If you meant to enable it by default, then $(ENABLE_IFRAME_SEAMLESS) should be part of FEATURE_DEFINES. If you meant to disable it by default, then it should still be part of FEATURE_DEFINES, but the macro itself should be defined to be the empty string.
Sigh. Yes. This is all so remarkably stupid. :) Yet more reason why I need to fix bug 85456. I'll fix the FEATURE_DEFINE setting in a later patch. :) Thanks!
Added to FEATURE_DEFINES in <http://trac.webkit.org/changeset/116367>.
Thanks!
You forgot to enable it in EFL port and now our seamless tests are no longer passing. I will address this in Bug 85861.
Thanks. Yup, this is the point of bug 85456, so folks don't have to worry about 8 build systems. :)