Bug 84342 - [EFL] Unskip passing web storage tests
: [EFL] Unskip passing web storage tests
Status: RESOLVED FIXED
: WebKit
WebKit EFL
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 84169 84170
:
  Show dependency treegraph
 
Reported: 2012-04-19 07:42 PST by
Modified: 2012-04-23 09:04 PST (History)


Attachments
tests gardening (5.34 KB, patch)
2012-04-19 13:21 PST, Thiago Marcos P. Santos
no flags Review Patch | Details | Formatted Diff | Diff
patch (5.36 KB, patch)
2012-04-20 14:08 PST, Thiago Marcos P. Santos
no flags Review Patch | Details | Formatted Diff | Diff
patch (5.35 KB, patch)
2012-04-20 14:29 PST, Thiago Marcos P. Santos
no flags Review Patch | Details | Formatted Diff | Diff
patch (5.34 KB, patch)
2012-04-21 03:48 PST, Thiago Marcos P. Santos
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Rebased! (5.30 KB, patch)
2012-04-23 07:45 PST, Thiago Marcos P. Santos
no flags Review Patch | Details | Formatted Diff | Diff
Rebased once again! (5.30 KB, patch)
2012-04-23 07:48 PST, Thiago Marcos P. Santos
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Rebased again! Not a lucky day. (5.27 KB, patch)
2012-04-23 08:24 PST, Thiago Marcos P. Santos
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-19 07:42:27 PST
Skip list and text expectations needs gardening when talking about database. After closing some bugs, we can reach the same passing as Qt and GTK on this area.
------- Comment #1 From 2012-04-19 13:21:10 PST -------
Created an attachment (id=137963) [details]
tests gardening
------- Comment #2 From 2012-04-20 14:08:14 PST -------
Created an attachment (id=138158) [details]
patch

Rebased the aging patch...
------- Comment #3 From 2012-04-20 14:22:02 PST -------
(From update of attachment 138158 [details])
Removing my cq+ flag; please upload another version without the OOPS line in the ChangeLog so it can be committed directly.
------- Comment #4 From 2012-04-20 14:29:39 PST -------
Created an attachment (id=138166) [details]
patch
------- Comment #5 From 2012-04-20 15:31:08 PST -------
(From update of attachment 138166 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=138166&action=review

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY.

I didn't mean literally only the OOPS :-) In general, you just say "Unreviewed gardening" or something like that, without the "Reviewed by" line.
------- Comment #6 From 2012-04-21 03:48:48 PST -------
Created an attachment (id=138230) [details]
patch

LOL, now you know why people should not work on friday until late night. :)
------- Comment #7 From 2012-04-23 07:35:19 PST -------
(From update of attachment 138230 [details])
Rejecting attachment 138230 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
mium/third_party/v8-i18n --revision 32 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 32.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 1 files

Full output: http://queues.webkit.org/results/12482814
------- Comment #8 From 2012-04-23 07:45:50 PST -------
Created an attachment (id=138345) [details]
Rebased!
------- Comment #9 From 2012-04-23 07:48:10 PST -------
Created an attachment (id=138346) [details]
Rebased once again!
------- Comment #10 From 2012-04-23 08:18:48 PST -------
(From update of attachment 138346 [details])
Rejecting attachment 138346 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11316 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 11316.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12479803
------- Comment #11 From 2012-04-23 08:24:22 PST -------
Created an attachment (id=138352) [details]
Rebased again! Not a lucky day.
------- Comment #12 From 2012-04-23 09:04:40 PST -------
(From update of attachment 138352 [details])
Clearing flags on attachment: 138352

Committed r114904: <http://trac.webkit.org/changeset/114904>
------- Comment #13 From 2012-04-23 09:04:46 PST -------
All reviewed patches have been landed.  Closing bug.