Bug 84342 – [EFL] Unskip passing web storage tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Thiago Marcos P. Santos]

Skip list and text expectations needs gardening when talking about database. After closing some bugs, we can reach the same passing as Qt and GTK on this area.

[Thiago Marcos P. Santos]

Created attachment 137963 [details]
tests gardening

[Thiago Marcos P. Santos]

Created attachment 138158 [details]
patch

Rebased the aging patch...

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138158 [details]
patch

Removing my cq+ flag; please upload another version without the OOPS line in the ChangeLog so it can be committed directly.

[Thiago Marcos P. Santos]

Created attachment 138166 [details]
patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138166 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138166&action=review

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY.

I didn't mean literally only the OOPS :-) In general, you just say "Unreviewed gardening" or something like that, without the "Reviewed by" line.

[Thiago Marcos P. Santos]

Created attachment 138230 [details]
patch

LOL, now you know why people should not work on friday until late night. :)

[WebKit Review Bot]

Comment on attachment 138230 [details]
patch

Rejecting attachment 138230 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
mium/third_party/v8-i18n --revision 32 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 32.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 1 files

Full output: http://queues.webkit.org/results/12482814

[Thiago Marcos P. Santos]

Created attachment 138345 [details]
Rebased!

[Thiago Marcos P. Santos]

Created attachment 138346 [details]
Rebased once again!

[WebKit Review Bot]

Comment on attachment 138346 [details]
Rebased once again!

Rejecting attachment 138346 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11316 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 11316.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12479803

[Thiago Marcos P. Santos]

Created attachment 138352 [details]
Rebased again! Not a lucky day.

[WebKit Review Bot]

Comment on attachment 138352 [details]
Rebased again! Not a lucky day.

Clearing flags on attachment: 138352

Committed r114904: <http://trac.webkit.org/changeset/114904>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.