Bug 84169 - [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
Summary: [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks: 84170 84342
  Show dependency treegraph
 
Reported: 2012-04-17 11:06 PDT by Thiago Marcos P. Santos
Modified: 2012-04-19 15:13 PDT (History)
4 users (show)

See Also:


Attachments
add DUMPRENDERTREE_TEMP support to EFL's DRT (1.54 KB, patch)
2012-04-19 13:17 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-04-17 11:06:22 PDT
DRT is creating all the databases inside ~/.webkit. This is causing unreliable/flaky tests results (specially when running tests in parallel).
Comment 1 Thiago Marcos P. Santos 2012-04-19 13:17:48 PDT
Created attachment 137960 [details]
add DUMPRENDERTREE_TEMP support to EFL's DRT
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-04-19 14:02:02 PDT
Comment on attachment 137960 [details]
add DUMPRENDERTREE_TEMP support to EFL's DRT

While the change does make the port behave more similarly to other ports, I'd be glad if you could share more details about the problems you were experiencing -- were multiple tests writing to the same locations or something like that?
Comment 3 Eric Seidel (no email) 2012-04-19 14:13:31 PDT
Comment on attachment 137960 [details]
add DUMPRENDERTREE_TEMP support to EFL's DRT

Icky String-concat api.
Comment 4 Thiago Marcos P. Santos 2012-04-19 14:23:34 PDT
(In reply to comment #2)
> (From update of attachment 137960 [details])
> While the change does make the port behave more similarly to other ports, I'd be glad if you could share more details about the problems you were experiencing -- were multiple tests writing to the same locations or something like that?

When running database tests, they will all create databases at ~/.webkit/. Some tests might be testing concurrency, quota, stress and all sort of things. It generates some random results and timeouts if many tests are running in parallel (and some fail due to other tests leftovers).

After this patch, they will go to a private temporary folder like /tmp/DumpRenderTree-ABCDE/Databases/ which is cleaned up later.

Not to mention that DRT might potentially screw up the developer environment since ~/.webkit is the default for EWK (imagine if you are working on a browser as well). :)
Comment 5 WebKit Review Bot 2012-04-19 15:12:57 PDT
Comment on attachment 137960 [details]
add DUMPRENDERTREE_TEMP support to EFL's DRT

Clearing flags on attachment: 137960

Committed r114682: <http://trac.webkit.org/changeset/114682>
Comment 6 WebKit Review Bot 2012-04-19 15:13:02 PDT
All reviewed patches have been landed.  Closing bug.