And unskip tests like: LayoutTests/storage/quota-tracking.html
Created attachment 137962 [details] define quota based on db origin
Bug 84342 will unskip all passing storage tests after this one lands.
Comment on attachment 137962 [details] define quota based on db origin View in context: https://bugs.webkit.org/attachment.cgi?id=137962&action=review > Tools/ChangeLog:6 > + Improved LayoutTestController::setDatabaseQuota to set quota based on Generally, we add description to below "Reviewed by NOBODY" > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:87 > +static uint64_t onExceededDatabaseQuota(Ewk_View_Smart_Data* smartData, Evas_Object *frame, const char *databaseName, uint64_t current_size, uint64_t expected_size) Style nit : We don't set '*' pointer on variable side.
(In reply to comment #3) > (From update of attachment 137962 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137962&action=review > > > Tools/ChangeLog:6 > > + Improved LayoutTestController::setDatabaseQuota to set quota based on > > Generally, we add description to below "Reviewed by NOBODY" > Well noticed. > > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:87 > > +static uint64_t onExceededDatabaseQuota(Ewk_View_Smart_Data* smartData, Evas_Object *frame, const char *databaseName, uint64_t current_size, uint64_t expected_size) > > Style nit : We don't set '*' pointer on variable side. I'm going to fix that. Wondering why check-webkit-style is not catching these... Thanks for reviewing.
Created attachment 138112 [details] patch
Attachment 138112 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/e..." exit_code: 1 Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:107: current_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:107: expected_size is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 138140 [details] patch
Comment on attachment 138140 [details] patch Clearing flags on attachment: 138140 Committed r114776: <http://trac.webkit.org/changeset/114776>
All reviewed patches have been landed. Closing bug.