Bug 83285 - [EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
Summary: [EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency treegraph
 
Reported: 2012-04-05 09:34 PDT by Mariusz Grzegorczyk
Modified: 2012-04-17 04:56 PDT (History)
13 users (show)

See Also:


Attachments
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro (32.40 KB, patch)
2012-04-05 09:43 PDT, Mariusz Grzegorczyk
no flags Details | Formatted Diff | Diff
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro (32.46 KB, patch)
2012-04-06 00:41 PDT, Mariusz Grzegorczyk
rniwa: review+
Details | Formatted Diff | Diff
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro (32.43 KB, patch)
2012-04-17 03:20 PDT, Mariusz Grzegorczyk
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mariusz Grzegorczyk 2012-04-05 09:34:18 PDT
After applying all patches related with master bug "[EFL][WK2] Support for EFL port of WebKit2": https://bugs.webkit.org/show_bug.cgi?id=61838 build break occurs because of disabled CONTEXT_MENUS macro.
Comment 1 Mariusz Grzegorczyk 2012-04-05 09:43:31 PDT
Created attachment 135841 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
Comment 2 WebKit Review Bot 2012-04-05 23:36:29 PDT
Attachment 135841 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/efl/WebCoreSupport/PageClientEfl.cpp:26:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mariusz Grzegorczyk 2012-04-06 00:41:33 PDT
Created attachment 135990 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
Comment 4 Grzegorz Czajkowski 2012-04-11 00:17:38 PDT
LGTM.

Some time ago patch https://bugs.webkit.org/show_bug.cgi?id=82342 has landed to repo that fixed build break when CONTEXT_MENUS is disabled in WebKit1. That patch generally improved WebCore and GTK, EFL ports of WebKit1.

We need to apply this patch for WK2 to compile EFL port because context menu is not supported for EFL port yet and has to be disabled.
Comment 5 Ryuan Choi 2012-04-17 02:44:48 PDT
Could you rebase this?
I can't apply this because of hunk failed on ewk_view.cpp
Comment 6 Mariusz Grzegorczyk 2012-04-17 03:20:17 PDT
Created attachment 137506 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro

Rebased version.
Comment 7 Ryuan Choi 2012-04-17 04:35:21 PDT
Comment on attachment 137506 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro

thanks
Comment 8 WebKit Review Bot 2012-04-17 04:56:37 PDT
Comment on attachment 137506 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro

Clearing flags on attachment: 137506

Committed r114367: <http://trac.webkit.org/changeset/114367>
Comment 9 WebKit Review Bot 2012-04-17 04:56:44 PDT
All reviewed patches have been landed.  Closing bug.