Bug 83285 – [EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Mariusz Grzegorczyk]

After applying all patches related with master bug "[EFL][WK2] Support for EFL port of WebKit2": https://bugs.webkit.org/show_bug.cgi?id=61838 build break occurs because of disabled CONTEXT_MENUS macro.

[Mariusz Grzegorczyk]

Created attachment 135841 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro

[WebKit Review Bot]

Attachment 135841 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/efl/WebCoreSupport/PageClientEfl.cpp:26:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mariusz Grzegorczyk]

Created attachment 135990 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro

[Grzegorz Czajkowski]

LGTM.

Some time ago patch https://bugs.webkit.org/show_bug.cgi?id=82342 has landed to repo that fixed build break when CONTEXT_MENUS is disabled in WebKit1. That patch generally improved WebCore and GTK, EFL ports of WebKit1.

We need to apply this patch for WK2 to compile EFL port because context menu is not supported for EFL port yet and has to be disabled.

[Ryuan Choi]

Could you rebase this?
I can't apply this because of hunk failed on ewk_view.cpp

[Mariusz Grzegorczyk]

Created attachment 137506 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro

Rebased version.

[Ryuan Choi]

Comment on attachment 137506 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro

thanks

[WebKit Review Bot]

Comment on attachment 137506 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro

Clearing flags on attachment: 137506

Committed r114367: <http://trac.webkit.org/changeset/114367>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.