Bug 82342 – Fix build break when CONTEXT_MENUS is disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mariusz Grzegorczyk]

When CONTEXT_MENUS macro is disabled build break occurs with following error:
../../Source/WebKit/gtk/webkit/webkitwebview.cpp: In function 'gboolean webkit_web_view_forward_context_menu_event(WebKitWebView*, const WebCore::PlatformMouseEvent&)':
../../Source/WebKit/gtk/webkit/webkitwebview.cpp:325:11: error: 'class WebCore::Page has no member named 'contextMenuController'
../../Source/WebKit/gtk/webkit/webkitwebview.cpp:355:55: error: 'class WebCore::EventHandler has no member named 'sendContextMenuEvent'
../../Source/WebKit/gtk/webkit/webkitwebview.cpp:362:47: error: 'class WebCore::Page has no member named 'contextMenuController'

[Mariusz Grzegorczyk]

Created attachment 134243 [details]
patch fixing GTK build break when CONTEXT_MENUS is disabled

[Gyuyoung Kim]

Comment on attachment 134243 [details]
patch fixing GTK build break when CONTEXT_MENUS is disabled

Attachment 134243 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12151084

[Mariusz Grzegorczyk]

Created attachment 134273 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

[Grzegorz Czajkowski]

LGTM.
CONTEXT_MENUS macro is disabled for WebKit2 EFL port. This patch is a first step to allow build WebKit2-EFL.
It's a base patch which allows further modifications related to specific components for example, WebKit2 and WebKtit-EFL. 

Could you review it, please?
Thanks

[Andreas Kling]

Comment on attachment 134273 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

View in context: https://bugs.webkit.org/attachment.cgi?id=134273&action=review

Sure, r=me.

> Source/WebCore/ChangeLog:3
> +        Fix build break when CONTEXT_MENUS is disabled.

Missing bug number here.

[Mariusz Grzegorczyk]

Created attachment 135085 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

Rebased, added bug number in changelog.

[Mariusz Grzegorczyk]

Created attachment 135086 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

[WebKit Review Bot]

Comment on attachment 135086 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

Rejecting attachment 135086 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 135086 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

Clearing flags on attachment: 135086

Committed r113147: <http://trac.webkit.org/changeset/113147>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.