Bug 82326 – Enable animVal support for SVGAnimatedPreserveAspectRatio

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

Enable animVal support for SVGAnimatedPreserveAspectRatio

[Nikolas Zimmermann]

Created attachment 134032 [details]
Patch

[Zoltan Herczeg]

Comment on attachment 134032 [details]
Patch

r=me

View in context: https://bugs.webkit.org/attachment.cgi?id=134032&action=review

> LayoutTests/svg/dom/preserve-aspect-ratio-parser.html:120
> +parsePreserveAspectRatio("",0, 0);

Missing space

[WebKit Review Bot]

Comment on attachment 134032 [details]
Patch

Attachment 134032 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12141533

New failing tests:
svg/custom/preserve-aspect-ratio-syntax.svg

[WebKit Review Bot]

Created attachment 134040 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Nikolas Zimmermann]

Committed r112391: <http://trac.webkit.org/changeset/112391>

[Csaba Osztrogonác]

(In reply to comment #3)
> (From update of attachment 134032 [details])
> Attachment 134032 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12141533
> 
> New failing tests:
> svg/custom/preserve-aspect-ratio-syntax.svg

It fails on GTK and Qt too. Could you check if the new results are correct or not?

[Nikolas Zimmermann]

Ouch it was listed as skipped in platform/mac-lion/Skipped, I couldn't notice this breakage - I reran all tests and they looked fine :(

I'll investigate, you can skip it for now.

[Ádám Kallai]

Thanks for your comment. I skipped this test on Qt.
Landed in: http://trac.webkit.org/changeset/112509

[Csaba Osztrogonác]

Reopen, because there is a failing test.

[Nikolas Zimmermann]

Patch at bug 82469 restores the old behavior and fixes the regression, once this lands I'll close this bug.