Bug 82326 - Enable animVal support for SVGAnimatedPreserveAspectRatio
Summary: Enable animVal support for SVGAnimatedPreserveAspectRatio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 12437 82469
Blocks: 41761 79666
  Show dependency tree / graph
 
Reported: 2012-03-27 05:03 PDT by Nikolas Zimmermann
Modified: 2012-03-31 12:29 PDT (History)
5 users (show)

See Also:

Attachments
Patch (29.76 KB, patch)
2012-03-27 05:11 PDT, Nikolas Zimmermann 		zherczeg: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (10.32 MB, application/zip)
2012-03-27 06:05 PDT, WebKit Review Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-03-27 05:03:38 PDT 
Enable animVal support for SVGAnimatedPreserveAspectRatio
Comment 1 Nikolas Zimmermann 2012-03-27 05:11:10 PDT 
Created attachment 134032 [details]
Patch
Comment 2 Zoltan Herczeg 2012-03-27 05:52:34 PDT 
Comment on attachment 134032 [details]
Patch

r=me

View in context: https://bugs.webkit.org/attachment.cgi?id=134032&action=review

> LayoutTests/svg/dom/preserve-aspect-ratio-parser.html:120
> +parsePreserveAspectRatio("",0, 0);

Missing space
Comment 3 WebKit Review Bot 2012-03-27 06:05:37 PDT 
Comment on attachment 134032 [details]
Patch

Attachment 134032 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12141533

New failing tests:
svg/custom/preserve-aspect-ratio-syntax.svg
Comment 4 WebKit Review Bot 2012-03-27 06:05:44 PDT 
Created attachment 134040 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Nikolas Zimmermann 2012-03-28 06:14:51 PDT 
Committed r112391: <http://trac.webkit.org/changeset/112391>
Comment 6 Csaba Osztrogonác 2012-03-28 07:15:52 PDT 
(In reply to comment #3)
> (From update of attachment 134032 [details])
> Attachment 134032 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12141533
> 
> New failing tests:
> svg/custom/preserve-aspect-ratio-syntax.svg

It fails on GTK and Qt too. Could you check if the new results are correct or not?
Comment 7 Nikolas Zimmermann 2012-03-28 07:27:11 PDT 
Ouch it was listed as skipped in platform/mac-lion/Skipped, I couldn't notice this breakage - I reran all tests and they looked fine :(

I'll investigate, you can skip it for now.
Comment 8 Ádám Kallai 2012-03-29 02:15:33 PDT 
Thanks for your comment. I skipped this test on Qt.
Landed in: http://trac.webkit.org/changeset/112509
Comment 9 Csaba Osztrogonác 2012-03-29 02:35:14 PDT 
Reopen, because there is a failing test.
Comment 10 Nikolas Zimmermann 2012-03-31 08:16:08 PDT 
Patch at bug 82469 restores the old behavior and fixes the regression, once this lands I'll close this bug.