Bug 81891 – [EFL] DRT should support LayoutTestController's dumpResourceLoadCallbacks()

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dominik Röttsches (drott)]

EFL DRT does not obey dumpResourceLoadCallbacks() issued by tests - 
HTTP callbacks should be caught and resource load log dumps should be perfomed.

cmp. GTK's willSendRequestCallback, didReceiveResponse, didFinishLoading, didFailLoadingWithError in GTK DumpRenderTree.cpp.

[Chris Dumez]

*** Bug 82437 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Created attachment 134728 [details]
Proposed patch

Implements full support in EFL's DRT for LayoutTestController's dumpResourceLoadCallbacks() and allows for the following test cases to be removed from the skip list:
  http/tests/misc/favicon-loads-with-icon-loading-override.html
  fast/loader/main-document-url-for-non-http-loads.html
  http/tests/misc/link-rel-icon-beforeload.html
  http/tests/misc/willCacheResponse-delegate-callback.html
  http/tests/misc/window-dot-stop.html
  http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
  http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
  http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
  http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
  http/tests/security/XFrameOptions/x-frame-options-deny.html
  http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
  http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
  http/tests/xmlhttprequest/abort-should-cancel-load.html

[Chris Dumez]

Created attachment 134743 [details]
Proposed patch

willSendRequest should be dumped even if willSendRequestReturnsNull is set. Fixed the patch to reflect this.

[Chris Dumez]

Created attachment 134770 [details]
Proposed patch

Updated the patch to address the following issues:
- Should not dump NSError failing url if empty
- Use different domains for WebKit and NSURL errors (Optimally, error domains and codes should move to their own header at some point)

[Hajime Morrita]

Comment on attachment 134770 [details]
Proposed patch

Could you rebase and upload this? It looks the patch was uploaded in unfortunate timing by which bot didn't pick the patch.
The change itself looks sane.

[Chris Dumez]

Created attachment 136623 [details]
Proposed patch

Rebase on master

[Chris Dumez]

Created attachment 137487 [details]
Proposed patch

Rebased on master and split with #84129 to reduce patch size.

[Gyuyoung Kim]

Comment on attachment 137487 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137487&action=review

> Source/WebKit/efl/ChangeLog:9
> +        Implement support for LayoutTestController's 
> +        dumpResourceLoadCallbacks() in EFL's DumpRenderTree.

Description in ChangeLog is poor beside patch size.

> Tools/ChangeLog:9
> +        dumpResourceLoadCallbacks() in EFL's DumpRenderTree.

ditto.

[Chris Dumez]

Created attachment 137509 [details]
Proposed patch

Improve Changelogs' descriptions based on Gyuyoung Kim's feedback.

[Chris Dumez]

Created attachment 138053 [details]
Patch

Rebase on master.

[Chris Dumez]

Splitting with 84670 to facilitate review.

[Chris Dumez]

Created attachment 138951 [details]
Patch

Rebase on master now that patch from bug 84670 has landed.

[Gyuyoung Kim]

Comment on attachment 138951 [details]
Patch

It looks there is no critical problem. Looks fine.

[WebKit Review Bot]

Comment on attachment 138951 [details]
Patch

Clearing flags on attachment: 138951

Committed r115415: <http://trac.webkit.org/changeset/115415>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.