Bug 84129 - [EFL] ResourceError domain needs to be properly set in FrameLoaderClient
Summary: [EFL] ResourceError domain needs to be properly set in FrameLoaderClient
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on: 81891
Blocks: 82704
  Show dependency treegraph
Reported: 2012-04-17 00:28 PDT by Chris Dumez
Modified: 2012-05-06 22:51 PDT (History)
5 users (show)

See Also:

Proposed patch (6.21 KB, patch)
2012-04-17 04:50 PDT, Chris Dumez
japhet: review+
Details | Formatted Diff | Diff
Patch (6.15 KB, patch)
2012-04-27 03:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-04-17 00:28:48 PDT
Currently, EFL's FrameLoaderClient sets the ResourceError's domain to "Error", no matter what kind of error it is.
The ResourceError's needs to be appropriately set so that it is possible to distinguish NSURL errors from WebKit errors.

This functionality is needed in the DumpRenderTree to generate correct output for LayoutTestController's dumpResourceLoadCallbacks().
Comment 1 Chris Dumez 2012-04-17 04:50:24 PDT
Created attachment 137515 [details]
Proposed patch
Comment 2 Chris Dumez 2012-04-27 03:12:08 PDT
Comment on attachment 137515 [details]
Proposed patch

Clear cq? flag since the patch needs rebasing.
Comment 3 Gyuyoung Kim 2012-04-27 03:15:47 PDT
Yes, plz submit rebased patch again. Request only cq?. In addition, write reviewer name in changelog.
Comment 4 Chris Dumez 2012-04-27 03:21:27 PDT
Created attachment 139162 [details]

Patch for landing.
Comment 5 WebKit Review Bot 2012-04-27 11:05:14 PDT
Comment on attachment 139162 [details]

Clearing flags on attachment: 139162

Committed r115451: <http://trac.webkit.org/changeset/115451>
Comment 6 WebKit Review Bot 2012-04-27 11:05:19 PDT
All reviewed patches have been landed.  Closing bug.