Bug 84670 – [EFL][DRT] "resource,request,willsend" signal needs to provide more information

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

The "resource,request,willsend" signal only provide some information about the network request currently. This information is not enough to support LayoutTestController's dumpResourceLoadCallbacks() in EFL's DumpRenderTree. We need to provide more information about the network request as well as information about the possible redirect response.

[Chris Dumez]

Created attachment 138497 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 138497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138497&action=review

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:200
> +        redirectResponse = &responseBuffer;

I wonder why you don't use redirectResponse directly in order to send messages to application via signal.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:201
> +    }

Add blank line to here.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:203
> +

It is better to remove blank line.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:205
> +

ditto.

[Chris Dumez]

Created attachment 138756 [details]
Patch

Fix blank lines issues.

[Gyuyoung Kim]

One more question. Is there any unskip test by this patch?

[Chris Dumez]

Gyuyoung: No. As explained, the patch is split in several parts (84670, 	81891, 84129). On its own, it does not allow unskipping test cases.

[Gyuyoung Kim]

Bug 81891 has unskip tests. Ok. LGTM.

[WebKit Review Bot]

Comment on attachment 138756 [details]
Patch

Clearing flags on attachment: 138756

Committed r115294: <http://trac.webkit.org/changeset/115294>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.