The "resource,request,willsend" signal only provide some information about the network request currently. This information is not enough to support LayoutTestController's dumpResourceLoadCallbacks() in EFL's DumpRenderTree. We need to provide more information about the network request as well as information about the possible redirect response.
Created attachment 138497 [details]
Comment on attachment 138497 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=138497&action=review
> + redirectResponse = &responseBuffer;
I wonder why you don't use redirectResponse directly in order to send messages to application via signal.
> + }
Add blank line to here.
It is better to remove blank line.
Created attachment 138756 [details]
Fix blank lines issues.
One more question. Is there any unskip test by this patch?
Gyuyoung: No. As explained, the patch is split in several parts (84670, 81891, 84129). On its own, it does not allow unskipping test cases.
Bug 81891 has unskip tests. Ok. LGTM.
Comment on attachment 138756 [details]
Clearing flags on attachment: 138756
Committed r115294: <http://trac.webkit.org/changeset/115294>
All reviewed patches have been landed. Closing bug.