Bug 84670 - [EFL][DRT] "resource,request,willsend" signal needs to provide more information
Summary: [EFL][DRT] "resource,request,willsend" signal needs to provide more information
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 81891
  Show dependency treegraph
Reported: 2012-04-23 23:15 PDT by Chris Dumez
Modified: 2012-05-06 22:52 PDT (History)
5 users (show)

See Also:

Patch (16.48 KB, patch)
2012-04-23 23:24 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (16.48 KB, patch)
2012-04-25 01:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-04-23 23:15:50 PDT
The "resource,request,willsend" signal only provide some information about the network request currently. This information is not enough to support LayoutTestController's dumpResourceLoadCallbacks() in EFL's DumpRenderTree. We need to provide more information about the network request as well as information about the possible redirect response.
Comment 1 Chris Dumez 2012-04-23 23:24:26 PDT
Created attachment 138497 [details]
Comment 2 Gyuyoung Kim 2012-04-25 00:38:55 PDT
Comment on attachment 138497 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=138497&action=review

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:200
> +        redirectResponse = &responseBuffer;

I wonder why you don't use redirectResponse directly in order to send messages to application via signal.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:201
> +    }

Add blank line to here.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:203
> +

It is better to remove blank line.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:205
> +

Comment 3 Chris Dumez 2012-04-25 01:13:22 PDT
Created attachment 138756 [details]

Fix blank lines issues.
Comment 4 Gyuyoung Kim 2012-04-25 01:50:45 PDT
One more question. Is there any unskip test by this patch?
Comment 5 Chris Dumez 2012-04-25 01:53:24 PDT
Gyuyoung: No. As explained, the patch is split in several parts (84670, 	81891, 84129). On its own, it does not allow unskipping test cases.
Comment 6 Gyuyoung Kim 2012-04-25 01:54:34 PDT
Bug 81891 has unskip tests. Ok. LGTM.
Comment 7 WebKit Review Bot 2012-04-26 00:08:50 PDT
Comment on attachment 138756 [details]

Clearing flags on attachment: 138756

Committed r115294: <http://trac.webkit.org/changeset/115294>
Comment 8 WebKit Review Bot 2012-04-26 00:09:00 PDT
All reviewed patches have been landed.  Closing bug.