Bug 81353 - Moves remaining filesystem files to Modules/filesystem/
Summary: Moves remaining filesystem files to Modules/filesystem/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
: 81111 81149 (view as bug list)
Depends on:
Blocks: 81393
  Show dependency treegraph
 
Reported: 2012-03-16 08:10 PDT by Mark Pilgrim (Google)
Modified: 2012-03-16 19:37 PDT (History)
10 users (show)

See Also:


Attachments
Patch (533.14 KB, patch)
2012-03-16 08:12 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-03-16 08:10:50 PDT
Moves remaining filesystem files to Modules/filesystem/
Comment 1 Mark Pilgrim (Google) 2012-03-16 08:12:22 PDT
Created attachment 132286 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-03-16 08:14:03 PDT
*** Bug 81111 has been marked as a duplicate of this bug. ***
Comment 3 Mark Pilgrim (Google) 2012-03-16 08:14:15 PDT
*** Bug 81149 has been marked as a duplicate of this bug. ***
Comment 4 WebKit Review Bot 2012-03-16 08:16:45 PDT
Attachment 132286 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/filesystem/FileSystemCallbacks.h:68:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/DOMFilePath.cpp:71:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/filesystem/EntryArray.h:51:  The parameter name "entry" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/AsyncFileWriter.h:45:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/filesystem/DOMFilePath.h:71:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/FileWriter.cpp:173:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:69:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:70:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/FileEntry.h:57:  The parameter name "fileSystem" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:54:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:55:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:56:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:57:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:58:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/AsyncFileWriterClient.h:42:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 16 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Adam Barth 2012-03-16 12:53:52 PDT
Comment on attachment 132286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132286&action=review

Looks great.  Thanks.

> Source/WebCore/Modules/filesystem/DOMFilePath.h:41
> +class DOMFilePath {

Should this class have an ENABLE(FILE_SYSTEM) ifdef?
Comment 6 Mark Pilgrim (Google) 2012-03-16 12:55:58 PDT
Probably. I'll add it in a separate patch once this goes through.
Comment 7 WebKit Review Bot 2012-03-16 13:54:14 PDT
Comment on attachment 132286 [details]
Patch

Rejecting attachment 132286 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
urce/WebKit/chromium/third_party/skia/third_party/glu --revision 3381 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
41>At revision 3381.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11964390
Comment 8 WebKit Review Bot 2012-03-16 15:00:29 PDT
Comment on attachment 132286 [details]
Patch

Clearing flags on attachment: 132286

Committed r111075: <http://trac.webkit.org/changeset/111075>
Comment 9 WebKit Review Bot 2012-03-16 15:00:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Yael 2012-03-16 19:37:49 PDT
Qt build fix was committed in http://trac.webkit.org/changeset/111106