Bug 81111 - Move EntryArray, EntryBase, EntryCallback, and Entry to Modules/filesystem/
Summary: Move EntryArray, EntryBase, EntryCallback, and Entry to Modules/filesystem/
Status: RESOLVED DUPLICATE of bug 81353
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-14 08:17 PDT by Mark Pilgrim (Google)
Modified: 2012-03-20 00:56 PDT (History)
6 users (show)

See Also:

Attachments
Patch (113.09 KB, patch)
2012-03-14 08:19 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (114.39 KB, patch)
2012-03-15 10:33 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-03-14 08:17:15 PDT 
Move EntryArray, EntryBase, EntryCallback, and Entry to Modules/filesystem/
Comment 1 Mark Pilgrim (Google) 2012-03-14 08:19:08 PDT 
Created attachment 131852 [details]
Patch
Comment 2 Build Bot 2012-03-14 08:47:19 PDT 
Comment on attachment 131852 [details]
Patch

Attachment 131852 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11958060
Comment 3 WebKit Review Bot 2012-03-14 09:11:53 PDT 
Comment on attachment 131852 [details]
Patch

Attachment 131852 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11957073
Comment 4 Mark Pilgrim (Google) 2012-03-15 10:33:18 PDT 
Created attachment 132074 [details]
Patch
Comment 5 WebKit Review Bot 2012-03-15 10:36:09 PDT 
Attachment 132074 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/filesystem/EntryArray.h:51:  The parameter name "entry" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:54:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:55:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:56:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:57:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:58:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Build Bot 2012-03-15 11:07:13 PDT 
Comment on attachment 132074 [details]
Patch

Attachment 132074 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11952907
Comment 7 WebKit Review Bot 2012-03-15 11:34:08 PDT 
Comment on attachment 132074 [details]
Patch

Attachment 132074 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11956706
Comment 8 Mark Pilgrim (Google) 2012-03-16 08:14:03 PDT 

*** This bug has been marked as a duplicate of bug 81353 ***
Comment 9 Eric Seidel (no email) 2012-03-20 00:56:11 PDT 
Comment on attachment 132074 [details]
Patch

Cleared review? from attachment 132074 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).