Bug 81149 – Move DOMFilePath and DOMFileSystem* to Modules/filesystem/

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Mark Pilgrim (Google)]

Move DOMFilePath and DOMFileSystem* to Modules/filesystem/

[Mark Pilgrim (Google)]

Created attachment 131907 [details]
Patch

[Build Bot]

Comment on attachment 131907 [details]
Patch

Attachment 131907 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11956205

[Adam Barth]

Comment on attachment 131907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131907&action=review

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:24060
> +				        RelativePath="..\fileapi\DOMFilePath.cpp"

These look like the wrong paths.

[Mark Pilgrim (Google)]

Created attachment 131923 [details]
Patch

[Adam Barth]

Comment on attachment 131923 [details]
Patch

These files are the correct ones to move, but it looks like you need to update to top-of-tree to create a patch that applies.

[Mark Pilgrim (Google)]

Created attachment 132077 [details]
Patch

[WebKit Review Bot]

Attachment 132077 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/filesystem/DOMFilePath.cpp:71:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/filesystem/DOMFilePath.h:71:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:69:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:70:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 132077 [details]
Patch

Attachment 132077 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11956698

[Mark Pilgrim (Google)]

*** This bug has been marked as a duplicate of bug 81353 ***

[Eric Seidel (no email)]

Comment on attachment 132077 [details]
Patch

Cleared review? from attachment 132077 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).