Bug 80758 - Enable animVal support for SVGTransformList
Summary: Enable animVal support for SVGTransformList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 12437 80750
Blocks: 41761
  Show dependency treegraph
 
Reported: 2012-03-10 07:33 PST by Nikolas Zimmermann
Modified: 2012-03-15 06:11 PDT (History)
3 users (show)

See Also:


Attachments
Draft patch (59.36 KB, patch)
2012-03-10 07:34 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch (67.74 KB, patch)
2012-03-15 04:01 PDT, Nikolas Zimmermann
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-03-10 07:33:40 PST
Introduce SVGAnimatedTransformList, to handle transform lists like any other lists within the SVGAnimatedType concept.
This allow us to completely remove the SVGAnimateTransformElement implementation and make SVGAnimateTransformElement inherit from SVGAnimateElement instead.
As side-effect this gives full animVal support for <animateTransform>.

This bug depends on both the initial animVal patch at bug 12437 plus the patch at bug 80750 adding support for SVGLengthList.
Comment 1 Nikolas Zimmermann 2012-03-10 07:34:47 PST
Created attachment 131173 [details]
Draft patch

Not meant for review yet - depends on both patches mentioned in the description.
Comment 2 Nikolas Zimmermann 2012-03-15 04:01:40 PDT
Created attachment 132016 [details]
Patch
Comment 3 Antti Koivisto 2012-03-15 04:26:23 PDT
Comment on attachment 132016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132016&action=review

r=me

> Source/WebCore/svg/SVGAnimatedTransformList.cpp:3
> +/*
> + * Copyright (C) Research In Motion Limited 2012. All rights reserved.
> + *

You might want to preserve the copyright as this code is at least based on the original code.

> Source/WebCore/svg/SVGAnimatedTransformList.cpp:92
> +    // âtoâ attribute value, which conflicts mathematically with the requirement for additive transform animations

Strange characters around 'to', but maybe it is just bugzilla?
Comment 4 Nikolas Zimmermann 2012-03-15 06:11:31 PDT
Committed r110838: <http://trac.webkit.org/changeset/110838>