Bug 80750 - Enable animVal support for SVGLengthList
Summary: Enable animVal support for SVGLengthList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 12437
Blocks: 41761 80758
  Show dependency tree / graph
 
Reported: 2012-03-10 01:43 PST by Nikolas Zimmermann
Modified: 2012-03-15 03:01 PDT (History)
4 users (show)

See Also:

Attachments
Draft patch (73.00 KB, patch)
2012-03-10 02:13 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch (94.11 KB, patch)
2012-03-13 03:29 PDT, Nikolas Zimmermann 		zherczeg: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-03-10 01:43:20 PST 
Enable animVal support for SVGLengthList. This is the next logical step after bug 12437 lands, which implements animVal support for SVGLength.
Once these two types are converted, all the ground work is done, and converting more types to use animVal is easy.
Comment 1 Nikolas Zimmermann 2012-03-10 02:13:10 PST 
Created attachment 131166 [details]
Draft patch

Not meant for review yet, just to show the path on how to go on after 12437 landed.
Comment 2 Nikolas Zimmermann 2012-03-13 03:29:09 PDT 
Created attachment 131583 [details]
Patch
Comment 3 Zoltan Herczeg 2012-03-13 05:18:34 PDT 
Comment on attachment 131583 [details]
Patch

Wow another huga patch. Makes sense, only a few comments

View in context: https://bugs.webkit.org/attachment.cgi?id=131583&action=review

> Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:78
> +    virtual SVGGenericAnimatedType* currentBaseValue(AnimatedPropertyType expectedPropertyType) const

Why these virtual functions goes into the header? Thay cannot be inlined.

> Source/WebCore/svg/properties/SVGListProperty.h:57
> +        // See SVGPropertyTearOff::detachWrapper() for an explaination what's happening here.

explanation
Comment 4 Nikolas Zimmermann 2012-03-13 07:59:20 PDT 
(In reply to comment #3)
> Why these virtual functions goes into the header? Thay cannot be inlined.
There is no cpp file where I could move this, its a template class?
Comment 5 Zoltan Herczeg 2012-03-14 02:36:38 PDT 
Comment on attachment 131583 [details]
Patch

Nice patch. r=me
Comment 6 Nikolas Zimmermann 2012-03-15 03:01:17 PDT 
Committed r110835: <http://trac.webkit.org/changeset/110835>