Inject internals object for EFL DRT.
Created attachment 129432 [details] Patch
Created attachment 129457 [details] Patch that injects "internals" on the window object and also removes tests relying on this feature from skip lists. I know there is a patch on the review queue already. I ended up duplicating this work because the bugzilla was down today and I could not search if there was some work ongoing on this already. :(
Comment on attachment 129432 [details] Patch Attachment 129432 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11770168
Comment on attachment 129457 [details] Patch that injects "internals" on the window object and also removes tests relying on this feature from skip lists. I love patches which make the skipped list smaller :-) Looks fine.
I also think EFL port needs this patch. LGTM.
Comment on attachment 129457 [details] Patch that injects "internals" on the window object and also removes tests relying on this feature from skip lists. testing stuff is not a part of WebCore. bug 79896 adds a new WebCoreTestSupport library. But adding the change to the Skipped list, to the other path at this bug makes sense
Created attachment 131462 [details] New patch taking into account changes made by 79896.
will have few more for you to unskip when https://bugs.webkit.org/show_bug.cgi?id=80886 lands :-)
In LayoutTests/platform/efl/Skipped -># EFL's LayoutTestController does not implement shadowRoot IMHO, above description will be not valid if this patch lands. Can you modify it? (In reply to comment #7) > Created an attachment (id=131462) [details] > New patch taking into account changes made by 79896.
This is great! :) Thanks! (In reply to comment #8) > will have few more for you to unskip when https://bugs.webkit.org/show_bug.cgi?id=80886 lands :-)
Comment on attachment 131462 [details] New patch taking into account changes made by 79896. Attachment 131462 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11943318
Created attachment 131589 [details] New patch fixing issues pointed by comments
LGTM Thanks! (In reply to comment #12) > Created an attachment (id=131589) [details] > New patch fixing issues pointed by comments
(In reply to comment #9) > In LayoutTests/platform/efl/Skipped > -># EFL's LayoutTestController does not implement shadowRoot > > IMHO, above description will be not valid if this patch lands. > Can you modify it? > Done, thanks for pointing out. BTW there are 2 tests that I had to kept on the skip list that are failing only for EFL, but I don't really now the reason. I'm working on those right now and I'll open a bug as soon as I find what is happening. fast/forms/color/input-color-onchange-event.html fast/html/details-clone.html > (In reply to comment #7) > > Created an attachment (id=131462) [details] [details] > > New patch taking into account changes made by 79896.
I will look forward to your upcoming patch(es). :) (In reply to comment #14) > (In reply to comment #9) > > In LayoutTests/platform/efl/Skipped > > -># EFL's LayoutTestController does not implement shadowRoot > > > > IMHO, above description will be not valid if this patch lands. > > Can you modify it? > > > > Done, thanks for pointing out. BTW there are 2 tests that I had to kept on the skip list that are failing only for EFL, but I don't really now the reason. I'm working on those right now and I'll open a bug as soon as I find what is happening. > > fast/forms/color/input-color-onchange-event.html > fast/html/details-clone.html > > > > (In reply to comment #7) > > > Created an attachment (id=131462) [details] [details] [details] > > > New patch taking into account changes made by 79896.
(In reply to comment #12) > Created an attachment (id=131589) [details] > New patch fixing issues pointed by comments do you want review? :-)
(In reply to comment #16) > (In reply to comment #12) > > Created an attachment (id=131589) [details] [details] > > New patch fixing issues pointed by comments > > do you want review? :-) Please. I was waiting for the EWS before poking you. :)
Comment on attachment 131589 [details] New patch fixing issues pointed by comments Clearing flags on attachment: 131589 Committed r110619: <http://trac.webkit.org/changeset/110619>
Patch was landed, closing.
Comment on attachment 129432 [details] Patch Cleared review? from attachment 129432 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).