Bug 81027 - [EFL] Enable HTML5 Summary and Details elements
Summary: [EFL] Enable HTML5 Summary and Details elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on: 79900
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-13 13:12 PDT by Thiago Marcos P. Santos
Modified: 2012-03-14 10:32 PDT (History)
8 users (show)

See Also:

Attachments
Enables Details and Summary elements. (100.24 KB, patch)
2012-03-13 15:47 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-03-13 13:12:26 PDT 
Looks like this feature is enabled for all ports, except EFL. I see no reason for that.
Comment 1 Thiago Marcos P. Santos 2012-03-13 13:14:21 PDT 
Added dependency since some of the tests for validating the feature depends on window.internals.
Comment 2 Thiago Marcos P. Santos 2012-03-13 15:47:38 PDT 
Created attachment 131736 [details]
Enables Details and Summary elements.
Comment 3 Gyuyoung Kim 2012-03-13 17:31:52 PDT 
It seems to me there is no critical problem to support ENALBE(DETAILS) on EFL port.

Could you let me know a result of layout test after this patch ?
Comment 4 Thiago Marcos P. Santos 2012-03-13 23:00:28 PDT 
(In reply to comment #3)
> It seems to me there is no critical problem to support ENALBE(DETAILS) on EFL port.
> 
> Could you let me know a result of layout test after this patch ?

On my machine (Ubuntu 11.10 + EFL-svn), all the tests I removed from the skip list on this patch are passing now.

I tested rendering some Summary/Details code examples with Chromium 17, GtkLauncher and EWebLauncher. The results were all the same, at least for my poor colorblind eyes. :)
Comment 5 WebKit Review Bot 2012-03-14 10:32:45 PDT 
Comment on attachment 131736 [details]
Enables Details and Summary elements.

Clearing flags on attachment: 131736

Committed r110713: <http://trac.webkit.org/changeset/110713>
Comment 6 WebKit Review Bot 2012-03-14 10:32:50 PDT 
All reviewed patches have been landed.  Closing bug.