Bug 80886 - Convert nodesFromRect tests to use Internals interface
Summary: Convert nodesFromRect tests to use Internals interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks: 80847
  Show dependency treegraph
 
Reported: 2012-03-12 14:13 PDT by Antonio Gomes
Modified: 2012-03-13 13:07 PDT (History)
6 users (show)

See Also:


Attachments
patch v1 (27.54 KB, patch)
2012-03-12 16:42 PDT, Antonio Gomes
gns: commit-queue-
Details | Formatted Diff | Diff
patch v2 - buildfixes for gtk and win (attempt) (30.51 KB, patch)
2012-03-13 09:40 PDT, Antonio Gomes
buildbot: commit-queue-
Details | Formatted Diff | Diff
(committed r110594 r=rniwa) patch v3 - win buildfixes - more symbols exported (31.01 KB, patch)
2012-03-13 10:26 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-03-12 14:13:17 PDT
It will make it easier to extend it for future tests, given that there won't be mac, gtk and qt specific LayoutTestController implementations anymore.
Comment 1 Antonio Gomes 2012-03-12 14:35:26 PDT
Patch coming..
Comment 2 Antonio Gomes 2012-03-12 16:42:14 PDT
Created attachment 131450 [details]
patch v1
Comment 3 Gustavo Noronha (kov) 2012-03-12 19:32:30 PDT
Comment on attachment 131450 [details]
patch v1

Attachment 131450 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11945250
Comment 4 Build Bot 2012-03-12 23:14:07 PDT
Comment on attachment 131450 [details]
patch v1

Attachment 131450 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11947353
Comment 5 Antonio Gomes 2012-03-13 08:19:15 PDT
(In reply to comment #4)
> (From update of attachment 131450 [details])
> Attachment 131450 [details] did not pass win-ews (win):
> Output: http://queues.webkit.org/results/11947353

That is the window link failure:

10>Linking...
10>   Creating library C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\lib\DumpRenderTree.exp
10>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: class WTF::PassRefPtr<class WebCore::NodeList> __thiscall WebCore::Document::nodesFromRect(int,int,unsigned int,unsigned int,unsigned int,unsigned int,bool)const " (?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIII_N@Z) referenced in function "public: class WTF::PassRefPtr<class WebCore::NodeList> __thiscall WebCore::Internals::nodesFromRect(class WebCore::Document *,int,int,unsigned int,unsigned int,unsigned int,unsigned int,bool,int &)const " (?nodesFromRect@Internals@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@PAVDocument@2@HHIIII_NAAH@Z)
10>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::NodeList *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNodeList@1@@Z) referenced in function "__int64 __fastcall WebCore::jsInternalsPrototypeFunctionNodesFromRect(class JSC::ExecState *)" (?jsInternalsPrototypeFunctionNodesFromRect@WebCore@@YI_JPAVExecState@JSC@@@Z)
10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\bin\DumpRenderTree.dll : fatal error LNK1120: 2 unresolved externals
10>Build log was saved at "file://C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\obj\DumpRenderTree\BuildLog.htm"
10>DumpRenderTree - 3 error(s), 0 warning(s)


@Jessie, would you know how can I fix it?
Comment 6 Jessie Berlin 2012-03-13 09:19:45 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 131450 [details] [details])
> > Attachment 131450 [details] [details] did not pass win-ews (win):
> > Output: http://queues.webkit.org/results/11947353
> 
> That is the window link failure:
> 
> 10>Linking...
> 10>   Creating library C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\lib\DumpRenderTree.exp
> 10>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: class WTF::PassRefPtr<class WebCore::NodeList> __thiscall WebCore::Document::nodesFromRect(int,int,unsigned int,unsigned int,unsigned int,unsigned int,bool)const " (?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIII_N@Z) referenced in function "public: class WTF::PassRefPtr<class WebCore::NodeList> __thiscall WebCore::Internals::nodesFromRect(class WebCore::Document *,int,int,unsigned int,unsigned int,unsigned int,unsigned int,bool,int &)const " (?nodesFromRect@Internals@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@PAVDocument@2@HHIIII_NAAH@Z)
> 10>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::NodeList *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNodeList@1@@Z) referenced in function "__int64 __fastcall WebCore::jsInternalsPrototypeFunctionNodesFromRect(class JSC::ExecState *)" (?jsInternalsPrototypeFunctionNodesFromRect@WebCore@@YI_JPAVExecState@JSC@@@Z)
> 10>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\bin\DumpRenderTree.dll : fatal error LNK1120: 2 unresolved externals
> 10>Build log was saved at "file://C:\cygwin\home\buildbot\WebKit\WebKitBuild\Debug\obj\DumpRenderTree\BuildLog.htm"
> 10>DumpRenderTree - 3 error(s), 0 warning(s)
> 
> 
> @Jessie, would you know how can I fix it?

I think you need to export these symbols in WebKit2.def (for an example, see http://trac.webkit.org/changeset/99613/trunk/Source/WebKit2/win/WebKit2.def).
Comment 7 Antonio Gomes 2012-03-13 09:40:36 PDT
Created attachment 131637 [details]
patch v2 - buildfixes for gtk and win (attempt)
Comment 8 Build Bot 2012-03-13 10:06:10 PDT
Comment on attachment 131637 [details]
patch v2 - buildfixes for gtk and win (attempt)

Attachment 131637 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11949503
Comment 9 Antonio Gomes 2012-03-13 10:26:10 PDT
Created attachment 131657 [details]
(committed r110594 r=rniwa) patch v3 - win buildfixes - more symbols exported
Comment 10 Ryosuke Niwa 2012-03-13 11:08:12 PDT
Comment on attachment 131657 [details]
(committed r110594 r=rniwa) patch v3 - win buildfixes - more symbols exported

View in context: https://bugs.webkit.org/attachment.cgi?id=131657&action=review

> Source/WebCore/testing/Internals.cpp:686
> +                                              unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding,

Nit: wrong indentation. We don't align arguments like this.

> Source/WebCore/testing/Internals.h:127
> +    PassRefPtr<NodeList> nodesFromRect(Document*, int /*x*/, int /*y*/,

We don't put variable names in comments

> Source/WebCore/testing/Internals.h:128
> +                                       unsigned /*topPadding*/, unsigned /*rightPadding*/, unsigned /*bottomPadding*/, unsigned /*leftPadding*/,

Ditto about the indentation

> Source/WebCore/testing/Internals.idl:102
> +        NodeList nodesFromRect(in Document document, in long x, in long y,

Ditto about the indentation