Bug 78524 - webkitpy should support Android
Summary: webkitpy should support Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 78528 78543 78545 78550 78558 78579 78580 78582 78627 79628
Blocks: 66687
  Show dependency tree / graph
 
Reported: 2012-02-13 13:41 PST by Adam Barth
Modified: 2012-02-26 23:01 PST (History)
2 users (show)

See Also:

Attachments
snapshot (40.86 KB, patch)
2012-02-13 13:41 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-13 13:41:20 PST 
webkitpy should support Android
Comment 1 Adam Barth 2012-02-13 13:41:43 PST 
Created attachment 126822 [details]
snapshot
Comment 2 Eric Seidel (no email) 2012-02-13 13:47:23 PST 
Comment on attachment 126822 [details]
snapshot

View in context: https://bugs.webkit.org/attachment.cgi?id=126822&action=review

I would have probably broken this file out into smaller pieces, but I think that's also something we can do later after the android port is working.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:493
> +class ChromiumAndroidDriver(chromium.ChromiumDriver):
> +    """Abstract interface for test_shell."""

Really?  We have yet another driver...?

> Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:78
> +        _set_gpu_options(self)

Odd function.

> Tools/Scripts/webkitpy/layout_tests/port/factory.py:76
> +            else:
> +                return 'chromium-linux'

No else after return.
Comment 3 Eric Seidel (no email) 2012-02-13 13:47:58 PST 
Comment on attachment 126822 [details]
snapshot

View in context: https://bugs.webkit.org/attachment.cgi?id=126822&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:50
> +_log = logging.getLogger('webkitpy.layout_tests.port.chromium_android')

I think we normally use getLogger(__file__)
Comment 4 Adam Barth 2012-02-14 17:04:25 PST 
This is done.  I don't have a target device, so it's hard for me to test that everything is working.  I suspect there are some bugs, but we can handle them separately as we find them.