Bug 78580 - Enable the GPU codepath in the chromium-android port
Summary: Enable the GPU codepath in the chromium-android port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 78524
  Show dependency treegraph
 
Reported: 2012-02-13 23:25 PST by Adam Barth
Modified: 2012-02-14 02:41 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.00 KB, patch)
2012-02-13 23:26 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2012-02-14 00:12 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (1.87 KB, patch)
2012-02-14 00:15 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-13 23:25:13 PST
Implement the ChromiumAndroidGPUPort
Comment 1 Adam Barth 2012-02-13 23:26:25 PST
Created attachment 126915 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-13 23:38:37 PST
Comment on attachment 126915 [details]
Patch

I thought the gpu ports were dead/default?
Comment 3 Adam Barth 2012-02-13 23:43:52 PST
> I thought the gpu ports were dead/default?

http://www.youtube.com/watch?v=Sh8mNjeuyV4
Comment 4 James Robinson 2012-02-13 23:48:59 PST
This seems really unnecessary.  We run everything in the Android port through the gpu path, so we should just declare that the default and not worry about the 'software' path until the time that we want to start using it.
Comment 5 James Robinson 2012-02-14 00:01:30 PST
Comment on attachment 126915 [details]
Patch

I'd suggest that you just make chromium_android set the gpu options unless there's some really compelling need to test a config we aren't planning to ship for a while.  To match what we ship, we really should set force compositing mode by default when running the android layout tests.
Comment 6 Adam Barth 2012-02-14 00:12:55 PST
Created attachment 126922 [details]
Patch
Comment 7 James Robinson 2012-02-14 00:14:38 PST
Comment on attachment 126922 [details]
Patch

R=me, probably want to change the bug title / checkin message to limit the inevitable confusion
Comment 8 Adam Barth 2012-02-14 00:15:49 PST
Created attachment 126923 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-02-14 02:41:18 PST
Comment on attachment 126923 [details]
Patch for landing

Clearing flags on attachment: 126923

Committed r107697: <http://trac.webkit.org/changeset/107697>
Comment 10 WebKit Review Bot 2012-02-14 02:41:23 PST
All reviewed patches have been landed.  Closing bug.