WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78580
Enable the GPU codepath in the chromium-android port
https://bugs.webkit.org/show_bug.cgi?id=78580
Summary
Enable the GPU codepath in the chromium-android port
Adam Barth
Reported
2012-02-13 23:25:13 PST
Implement the ChromiumAndroidGPUPort
Attachments
Patch
(4.00 KB, patch)
2012-02-13 23:26 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Patch
(1.85 KB, patch)
2012-02-14 00:12 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.87 KB, patch)
2012-02-14 00:15 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-02-13 23:26:25 PST
Created
attachment 126915
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-02-13 23:38:37 PST
Comment on
attachment 126915
[details]
Patch I thought the gpu ports were dead/default?
Adam Barth
Comment 3
2012-02-13 23:43:52 PST
> I thought the gpu ports were dead/default?
http://www.youtube.com/watch?v=Sh8mNjeuyV4
James Robinson
Comment 4
2012-02-13 23:48:59 PST
This seems really unnecessary. We run everything in the Android port through the gpu path, so we should just declare that the default and not worry about the 'software' path until the time that we want to start using it.
James Robinson
Comment 5
2012-02-14 00:01:30 PST
Comment on
attachment 126915
[details]
Patch I'd suggest that you just make chromium_android set the gpu options unless there's some really compelling need to test a config we aren't planning to ship for a while. To match what we ship, we really should set force compositing mode by default when running the android layout tests.
Adam Barth
Comment 6
2012-02-14 00:12:55 PST
Created
attachment 126922
[details]
Patch
James Robinson
Comment 7
2012-02-14 00:14:38 PST
Comment on
attachment 126922
[details]
Patch R=me, probably want to change the bug title / checkin message to limit the inevitable confusion
Adam Barth
Comment 8
2012-02-14 00:15:49 PST
Created
attachment 126923
[details]
Patch for landing
WebKit Review Bot
Comment 9
2012-02-14 02:41:18 PST
Comment on
attachment 126923
[details]
Patch for landing Clearing flags on attachment: 126923 Committed
r107697
: <
http://trac.webkit.org/changeset/107697
>
WebKit Review Bot
Comment 10
2012-02-14 02:41:23 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug