Bug 78558 - Implement start/stop_helper for ChromiumAndroidPort
Summary: Implement start/stop_helper for ChromiumAndroidPort
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 78524
  Show dependency treegraph
 
Reported: 2012-02-13 17:46 PST by Adam Barth
Modified: 2012-02-13 19:09 PST (History)
5 users (show)

See Also:


Attachments
Patch (11.27 KB, patch)
2012-02-13 17:48 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (11.83 KB, patch)
2012-02-13 17:52 PST, Adam Barth
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-13 17:46:20 PST
Implement start/stop_helper for ChromiumAndroidPort
Comment 1 Adam Barth 2012-02-13 17:48:33 PST
Created attachment 126874 [details]
Patch
Comment 2 Adam Barth 2012-02-13 17:52:07 PST
Created attachment 126876 [details]
Patch
Comment 3 Dirk Pranke 2012-02-13 17:56:24 PST
Comment on attachment 126876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126876&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:35
> +_log = logging.getLogger('webkitpy.layout_tests.port.chromium_android')

Nit: you should use __file__ here.
Comment 4 Adam Barth 2012-02-13 18:09:05 PST
> Nit: you should use __file__ here.

Gah!  (grepping around, it looks like we use __name__)
Comment 5 Adam Barth 2012-02-13 18:10:27 PST
Committed r107653: <http://trac.webkit.org/changeset/107653>
Comment 6 Eric Seidel (no email) 2012-02-13 18:13:39 PST
Sorry, yeah __name__ is likely better than __file__.  I too often get them confused.
Comment 7 Dirk Pranke 2012-02-13 19:09:11 PST
(In reply to comment #4)
> > Nit: you should use __file__ here.
> 
> Gah!  (grepping around, it looks like we use __name__)

Sorry! I meant __name__.