Bug 77183 - [Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
Summary: [Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html ti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 77736
  Show dependency treegraph
 
Reported: 2012-01-26 20:57 PST by Yuzo Fujishima
Modified: 2012-04-05 13:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2012-02-09 05:26 PST, Nikolas Zimmermann
zherczeg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuzo Fujishima 2012-01-26 20:57:23 PST
The following layout test times out (or passes) on Chromium.

svg/as-object/nested-embedded-svg-size-changes.html
Comment 1 Nikolas Zimmermann 2012-01-27 03:07:54 PST
My immediate thought was that its related to my FrameView patch, but it's a JS error:

CONSOLE MESSAGE: line 9: Uncaught TypeError: Cannot read property 'defaultView' of undefined
Maybe its V8 specific, I've never seen this fail before - "document" is null, at some point.
Comment 2 Nikolas Zimmermann 2012-02-03 08:29:59 PST
Bug 77736 might fix this, once landed.
Comment 3 Julien Chaffraix 2012-02-07 13:29:43 PST
FYI, I marked the test as slow to see if it helped and it really did not. We must be hitting the exception fairly regularly and not call notifyDone().
Comment 4 Nikolas Zimmermann 2012-02-08 02:27:16 PST
(In reply to comment #3)
> FYI, I marked the test as slow to see if it helped and it really did not. We must be hitting the exception fairly regularly and not call notifyDone().

*grml* It really needs to be debugged on Chrome/V8 - it only seems to happen there.
Comment 5 Nikolas Zimmermann 2012-02-09 02:44:04 PST
Not related to bug 77736 - it's a chromium/v8 specific problem.
Comment 6 Nikolas Zimmermann 2012-02-09 02:45:18 PST
Oops, wrong bug, reverting. Bug 78026 covers the same regression for Qt, which uses jsc.
Comment 7 Nikolas Zimmermann 2012-02-09 03:26:45 PST
Uploaded a fix to bug 78026 that should fix chromium as well.

*** This bug has been marked as a duplicate of bug 78026 ***
Comment 8 Nikolas Zimmermann 2012-02-09 05:05:52 PST
Reopening, it seems to be an individual failure, it doesn't fail on Qt at present.
Comment 9 Nikolas Zimmermann 2012-02-09 05:26:35 PST
Created attachment 126286 [details]
Patch
Comment 10 Zoltan Herczeg 2012-02-09 05:36:29 PST
Comment on attachment 126286 [details]
Patch

r=me
Comment 11 Nikolas Zimmermann 2012-02-09 05:40:10 PST
Committed r107227: <http://trac.webkit.org/changeset/107227>
Comment 12 Nikolas Zimmermann 2012-02-09 06:26:26 PST
Comment on attachment 126286 [details]
Patch

It got fixed in trunk! Manually verified using the latest layout test results.zip from the cr-linux bot, and discussed with podivilov on IRC.
Comment 13 Nikolas Zimmermann 2012-02-09 06:26:46 PST
Removed the TIMEOUT from the chromium expectations in r107231. Closing bug.
Comment 14 Stephen Chenney 2012-04-05 13:03:49 PDT
Committed r113362: <http://trac.webkit.org/changeset/113362>