Bug 76957 - nrwt: linting test_expectations doesn't quite work for the Qt port
Summary: nrwt: linting test_expectations doesn't quite work for the Qt port
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: NRWT
Depends on:
Blocks: 88680 89880
  Show dependency treegraph
Reported: 2012-01-24 16:19 PST by Dirk Pranke
Modified: 2013-11-07 08:09 PST (History)
5 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-01-24 16:19:29 PST
The current expectations Parser looks at all the configurations for a given port, but fails to account for different configurations having different lists of Skipped files (as in Qt, for example). So, "run-webkit-tests --lint-test-files --platform qt-mac" might pass and "run-webkit-tests --lint-test-files --platform qt-linux" might fail even though they share the same expectations file and the same list of test configurations.
Comment 1 Dirk Pranke 2012-06-14 13:37:38 PDT
there's several parts to this ...

1) should the linter warn when entries in an earlier file are overridden in a later file (since by design this is supposed to be okay)? I think the answer is, at least by default, no, but maybe there should be a flag to enable this, otherwise it will be easy for cruft to build up in top level files.

2) now that later files strictly override earlier files, files can be linted independently (if you don't want (1) to generate warnings), and we need to change the linter to actually track the contents of each file (especially since we can use dummy names for entries in the cascade that have the same name across ports but different values).

3) Since the results of the lint (depending on the answer in (1) ) are dependent on both the expectations and list of skips, clearly the linter needs to look at port.skipped_layout_tests() as well as the expectations files in order to determine if we've already linted the combination.
Comment 2 Csaba Osztrogonác 2013-11-07 08:09:18 PST
Qt isn't present in trunk.