Bug 75253 - [GTK] Implement zoom in/out in MiniBrowser
Summary: [GTK] Implement zoom in/out in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 75248
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-27 06:51 PST by Carlos Garcia Campos
Modified: 2012-02-17 03:10 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.67 KB, patch)
2011-12-27 06:52 PST, Carlos Garcia Campos
gustavo: review+
gustavo.noronha: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-12-27 06:51:08 PST
Add zoom in and out buttons to the toolbar.
Comment 1 Carlos Garcia Campos 2011-12-27 06:52:55 PST
Created attachment 120585 [details]
Patch
Comment 2 Collabora GTK+ EWS bot 2011-12-27 07:17:33 PST
Comment on attachment 120585 [details]
Patch

Attachment 120585 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11038352
Comment 3 Gustavo Noronha (kov) 2012-02-16 16:01:00 PST
Comment on attachment 120585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120585&action=review

Looks good. This doesn't depend on the decision in bug 75249, so I'll r+

> Tools/MiniBrowser/gtk/BrowserWindow.c:186
> +    return zoomLevel <= maximumZoomLevel;

I guess this should be zoomLevel < maximumZoomLevel, otherwise you would be reporting you can zoom in while being at the maximum zoom level.

> Tools/MiniBrowser/gtk/BrowserWindow.c:192
> +    return zoomLevel >= minimumZoomLevel;

Same here.
Comment 4 Carlos Garcia Campos 2012-02-17 03:10:20 PST
Committed r108056: <http://trac.webkit.org/changeset/108056>