Bug 75248 - [GTK] Add methods to get/set the WebView zoom level to WebKit2 GTK+ API
Summary: [GTK] Add methods to get/set the WebView zoom level to WebKit2 GTK+ API
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Blocks: 75249 75253
  Show dependency treegraph
Reported: 2011-12-27 06:32 PST by Carlos Garcia Campos
Modified: 2012-01-05 05:04 PST (History)
3 users (show)

See Also:

Patch (7.29 KB, patch)
2011-12-27 06:35 PST, Carlos Garcia Campos
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-12-27 06:32:20 PST
Add webkit_web_view_set_zoom_level() and webkit_web_view_get_zoom_level()
Comment 1 Carlos Garcia Campos 2011-12-27 06:35:15 PST
Created attachment 120579 [details]

It uses the page zoom factor unconditionally for now.
Comment 2 WebKit Review Bot 2011-12-27 06:38:08 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gustavo Noronha (kov) 2012-01-05 05:00:32 PST
Comment on attachment 120579 [details]

LGTM, for those not following along at home, the way this API will look in the future may change following discussions in the webkit-gtk mailing list, but this part here I think is pretty much a consensus will exist, even if the name changes to contain 'page' somewhere.
Comment 4 Carlos Garcia Campos 2012-01-05 05:04:58 PST
Committed r104145: <http://trac.webkit.org/changeset/104145>