Bug 75249 – [GTK] Add zoom-text-only setting to WebKit2 GTK+ API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

To set whether zoom level of web view should affect only the text or all page contents.

[Carlos Garcia Campos]

Created attachment 120581 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

As I said on the mailing list I'm not sure if "text-only" is entirely accurate.

[Gustavo Noronha (kov)]

I agree, Martin. How about we make the setting enable-full-content-zoom, enabled by default, instead? That way we stick to wk1's familiar existing property name and semantics, and do not use conceptually incorrect names. If you agree to that, I believe the patch is otherwise OK.

[Martin Robinson]

(In reply to comment #4)
> I agree, Martin. How about we make the setting enable-full-content-zoom, enabled by default, instead? That way we stick to wk1's familiar existing property name and semantics, and do not use conceptually incorrect names. If you agree to that, I believe the patch is otherwise OK.

Sure, sounds good to me.

[Carlos Garcia Campos]

We already agreed on the mailing list that 'text' is accurate and it's a reasonable name:

https://lists.webkit.org/pipermail/webkit-gtk/2011-December/000865.html

Form controls are scaled because they contain text, but text zoom factor is exactly that, so it's very accurate I would say. The text scale factor is applied to the font size.

[Gustavo Noronha (kov)]

Comment on attachment 120581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120581&action=review

Let's do this. We can always go back and review this API anyway =P

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:766
> +     * text of the page or all the contents.

Can you add a bit about text size also affecting things like form controls?

[Carlos Garcia Campos]

Committed r109229: <http://trac.webkit.org/changeset/109229>