Bug 75252 – [GTK] Use text or page zoom factor in WebKitWebView depending on zoom-text-only

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

Use the new setting to set/get the text or page zoom factor in WebKitWebView.

[Carlos Garcia Campos]

Created attachment 120583 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Gustavo Noronha (kov)]

Comment on attachment 120583 [details]
Patch

I think this patch could go in as part of the patch for bug 75249, it would make sense and it's not too big. It looks good to me, but the checks will need to be reversed if we decide to use enable-full-content-zoom in that other bug, might as well use the opportunity to squash it into the other one.

[Carlos Garcia Campos]

(In reply to comment #3)
> (From update of attachment 120583 [details])
> I think this patch could go in as part of the patch for bug 75249, it would make sense and it's not too big. It looks good to me, but the checks will need to be reversed if we decide to use enable-full-content-zoom in that other bug, might as well use the opportunity to squash it into the other one.

Ok, I don't mind to merge it. But I still find enable-full-content-zoom more confusing and inaccurate than zoom-text-only.

[Gustavo Noronha (kov)]

Comment on attachment 120583 [details]
Patch

Let's go ahead.

[Carlos Garcia Campos]

Committed r109230: <http://trac.webkit.org/changeset/109230>