RESOLVED FIXED 74981
Extract BlackBerry CMake arguments from build-webkit into separate function 
https://bugs.webkit.org/show_bug.cgi?id=74981
Summary Extract BlackBerry CMake arguments from build-webkit into separate function
Daniel Bates
Reported 2011-12-20 17:27:37 PST
Towards adding support to only build JavaScriptCore for the BlackBerry port using script Tools/Script/build-jsc, we need to extract the BlackBerry CMake arguments from build-webkit into a separate function so that we can call this function when passing the CMake arguments to webkitdirs::buildCMakeProjectOrExit() from within Tools/Script/build-{webkit, jsc}.
Attachments
Patch (11.80 KB, patch)
2011-12-20 17:42 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (12.31 KB, patch)
2011-12-21 11:25 PST, Daniel Bates 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2011-12-20 17:42:42 PST
Created attachment 120124 [details] Patch
Daniel Bates
Comment 2 2011-12-21 11:25:07 PST
Created attachment 120198 [details] Patch Updated the patch to integrate with webkitdirs::cmakeBasedPortArguments() following the landing of the patch for bug #74983.
WebKit Review Bot
Comment 3 2011-12-21 11:26:31 PST
Attachment 120198 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource It seems that I cannot create a rebase-apply directory, and I wonder if you are in the middle of patch application or another rebase. If that is not the case, please rm -fr /mnt/git/webkit-style-queue/.git/rebase-apply and run me again. I am stopping in case you still have something valuable there. rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 158. If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 4 2011-12-21 11:51:32 PST
Comment on attachment 120198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120198&action=review Looks good. > Tools/Scripts/webkitdirs.pm:932 > + push @cxxFlags, "-Wl,-rpath-link," . File::Spec->catfile($stageUsrLib, "torch-webkit"); We do not have the torch-webkit directory anymore, this needs to be removed in a follow-up patch.
Daniel Bates
Comment 5 2011-12-21 11:53:49 PST
(In reply to comment #4) > > Tools/Scripts/webkitdirs.pm:932 > > + push @cxxFlags, "-Wl,-rpath-link," . File::Spec->catfile($stageUsrLib, "torch-webkit"); > > We do not have the torch-webkit directory anymore, this needs to be removed in a follow-up patch. Will do.
Daniel Bates
Comment 6 2011-12-21 14:56:22 PST
Committed r103461: <http://trac.webkit.org/changeset/103461>
Note You need to log in before you can comment on or make changes to this bug.