Bug 74983 - Extract WinCE CMake arguments from build-webkit into separate function
Summary: Extract WinCE CMake arguments from build-webkit into separate function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 74979
Blocks: 74985
  Show dependency tree / graph
 
Reported: 2011-12-20 17:44 PST by Daniel Bates
Modified: 2011-12-21 11:09 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2011-12-20 17:59 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (2.69 KB, patch)
2011-12-21 10:33 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2011-12-20 17:44:24 PST 
Towards adding support to only build JavaScriptCore for the WinCE port using script Tools/Script/build-jsc, we need to extract the WinCE CMake argument from build-webkit into a separate function so that we can call this function when passing the CMake arguments to webkitdirs::buildCMakeProjectOrExit() from within Tools/Script/build-{webkit, jsc}.
Comment 1 Daniel Bates 2011-12-20 17:59:42 PST 
Created attachment 120129 [details]
Patch
Comment 2 Patrick R. Gansterer 2011-12-21 00:55:10 PST 
Comment on attachment 120129 [details]
Patch

what about changing this a "additional cmake arguments" function. Maby some other port need some additonal variables for the port too? otherwise LGTM
Comment 3 Daniel Bates 2011-12-21 10:33:50 PST 
Created attachment 120193 [details]
Patch

Added function webkitdirs::cmakeBasedPortArguments() and moved WinCE-specific CMake arguments into it. Also, use cmakeBasedPortArguments() when constructing the the list of CMake arguments for the EFL port. Currently, cmakeBasedPortArguments() returns the empty list for the EFL port.
Comment 4 Rob Buis 2011-12-21 11:00:53 PST 
Comment on attachment 120193 [details]
Patch

Looks good.
Comment 5 Daniel Bates 2011-12-21 11:09:47 PST 
Comment on attachment 120193 [details]
Patch

Clearing flags on attachment: 120193

Committed r103418: <http://trac.webkit.org/changeset/103418>
Comment 6 Daniel Bates 2011-12-21 11:09:53 PST 
All reviewed patches have been landed.  Closing bug.