WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
74979
Add CMake option to only build JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=74979
Summary
Add CMake option to only build JavaScriptCore
Daniel Bates
Reported
2011-12-20 17:11:43 PST
Towards implementing support for building JavaScriptCore using Tools/Scripts/build-jsc, add a CMake option to only build JavaScriptCore.
Attachments
Patch
(3.15 KB, patch)
2011-12-20 17:21 PST
,
Daniel Bates
rwlbuis
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2011-12-20 17:21:01 PST
Created
attachment 120121
[details]
Patch I thought to add a ENABLE_WEBCORE variable to enable/disable building WebCore similar to the existing variables ENABLE_WEBKIT and ENABLE_WEBKIT2. I then added a CMake option called ONLY_BUILD_JAVASCRIPTCORE that when defined sets ENABLE_WEB{CORE, KIT, KIT2} to Off. I am open to suggestions.
Rob Buis
Comment 2
2011-12-21 10:47:51 PST
Comment on
attachment 120121
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=120121&action=review
LGTM, please fix the default value thing before landing.
> CMakeLists.txt:15 > + SET(ENABLE_WEBCORE On)
Better to give ENABLE_WEBCORE the default value on.
Daniel Bates
Comment 3
2011-12-21 11:05:47 PST
Committed
r103417
: <
http://trac.webkit.org/changeset/103417
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug