Bug 74979 - Add CMake option to only build JavaScriptCore
Summary: Add CMake option to only build JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks: 74981 74983 74985
  Show dependency treegraph
 
Reported: 2011-12-20 17:11 PST by Daniel Bates
Modified: 2011-12-21 11:05 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.15 KB, patch)
2011-12-20 17:21 PST, Daniel Bates
rwlbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2011-12-20 17:11:43 PST
Towards implementing support for building JavaScriptCore using Tools/Scripts/build-jsc, add a CMake option to only build JavaScriptCore.
Comment 1 Daniel Bates 2011-12-20 17:21:01 PST
Created attachment 120121 [details]
Patch

I thought to add a ENABLE_WEBCORE variable to enable/disable building WebCore similar to the existing variables ENABLE_WEBKIT and ENABLE_WEBKIT2. I then added a CMake option called ONLY_BUILD_JAVASCRIPTCORE that when defined sets ENABLE_WEB{CORE, KIT, KIT2} to Off. I am open to suggestions.
Comment 2 Rob Buis 2011-12-21 10:47:51 PST
Comment on attachment 120121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120121&action=review

LGTM, please fix the default value thing before landing.

> CMakeLists.txt:15
> +    SET(ENABLE_WEBCORE On)

Better to give ENABLE_WEBCORE the default value on.
Comment 3 Daniel Bates 2011-12-21 11:05:47 PST
Committed r103417: <http://trac.webkit.org/changeset/103417>