Bug 74335 - Remove most uses of JSArray vptr
Summary: Remove most uses of JSArray vptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 74332
Blocks: 74331
  Show dependency tree / graph
 
Reported: 2011-12-12 14:26 PST by Mark Hahnenberg
Modified: 2011-12-18 12:22 PST (History)
0 users

See Also:

Attachments
Remove uses of JSArray vptr (38.05 KB, patch)
2011-12-12 14:48 PST, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-12-12 14:26:53 PST 
Similar to bug 74333, but we can't remove all of the uses because certain functions require other vptrs to be removed as well.
Comment 1 Mark Hahnenberg 2011-12-12 14:48:54 PST 
Created attachment 118858 [details]
Remove uses of JSArray vptr

No changelog (see bug 74331)
Comment 2 Geoffrey Garen 2011-12-12 14:58:57 PST 
Comment on attachment 118858 [details]
Remove uses of JSArray vptr

r=me
Comment 3 Geoffrey Garen 2011-12-12 15:00:21 PST 
Comment on attachment 118858 [details]
Remove uses of JSArray vptr

View in context: https://bugs.webkit.org/attachment.cgi?id=118858&action=review

> Source/JavaScriptCore/heap/MarkStack.cpp:315
> +    if (cell->classInfo() == &JSArray::s_info) {

Should use isJSArray().