Bug 74332 - Add ClassInfo* to JSCell
Summary: Add ClassInfo* to JSCell
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 74331 74333 74335 74336 74338
  Show dependency treegraph
 
Reported: 2011-12-12 14:23 PST by Mark Hahnenberg
Modified: 2011-12-18 12:22 PST (History)
0 users

See Also:


Attachments
Add ClassInfo to JSCell (8.17 KB, patch)
2011-12-12 14:46 PST, Mark Hahnenberg
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-12-12 14:23:04 PST
First step in de-virtualize destructors.  We need to be able to access the ClassInfo without depending on having the correct Structure.  This will make cell's temporarily bigger, and hence it will hurt performance.
Comment 1 Mark Hahnenberg 2011-12-12 14:46:06 PST
Created attachment 118854 [details]
Add ClassInfo to JSCell

There is no ChangeLog for this individual patch, as it will be part of a larger patch (see bug 74331).
Comment 2 Geoffrey Garen 2011-12-12 14:55:34 PST
Comment on attachment 118854 [details]
Add ClassInfo to JSCell

View in context: https://bugs.webkit.org/attachment.cgi?id=118854&action=review

r=me

> Source/JavaScriptCore/runtime/Structure.h:398
> +            m_structure.setEarlyValue(globalData, this, structure);

Please fix indentation.