Bug 74333 – Remove JSString vptr optimizations

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

We want to remove our dependence on the vptr being in the object prior to de-virtualizing all of the destructors.  We'll use the ClassInfo* that is now in JSCell instead.

[Mark Hahnenberg]

Created attachment 118856 [details]
Remove JSString vptr optimizations

No changelog, see bug 74331.

[WebKit Review Bot]

Attachment 118856 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/JavaScriptCore.exp',..." exit_code: 1

Source/JavaScriptCore/jit/JITOpcodes.cpp:52:  string_failureCases2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 118856 [details]
Remove JSString vptr optimizations

I'm starting to think that the comments you're putting in bugzilla would make good ChangeLog comments, too.

[Early Warning System Bot]

Comment on attachment 118856 [details]
Remove JSString vptr optimizations

Attachment 118856 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10847094

[Gyuyoung Kim]

Comment on attachment 118856 [details]
Remove JSString vptr optimizations

Attachment 118856 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10847113

[Gustavo Noronha (kov)]

Comment on attachment 118856 [details]
Remove JSString vptr optimizations

Attachment 118856 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10848214