Bug 74333 - Remove JSString vptr optimizations
Summary: Remove JSString vptr optimizations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 74332
Blocks: 74331
  Show dependency tree / graph
 
Reported: 2011-12-12 14:24 PST by Mark Hahnenberg
Modified: 2011-12-18 12:22 PST (History)
3 users (show)

See Also:

Attachments
Remove JSString vptr optimizations (25.03 KB, patch)
2011-12-12 14:47 PST, Mark Hahnenberg 		ggaren: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-12-12 14:24:36 PST 
We want to remove our dependence on the vptr being in the object prior to de-virtualizing all of the destructors.  We'll use the ClassInfo* that is now in JSCell instead.
Comment 1 Mark Hahnenberg 2011-12-12 14:47:06 PST 
Created attachment 118856 [details]
Remove JSString vptr optimizations

No changelog, see bug 74331.
Comment 2 WebKit Review Bot 2011-12-12 14:49:56 PST 
Attachment 118856 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/JavaScriptCore.exp',..." exit_code: 1

Source/JavaScriptCore/jit/JITOpcodes.cpp:52:  string_failureCases2 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2011-12-12 14:57:39 PST 
Comment on attachment 118856 [details]
Remove JSString vptr optimizations

I'm starting to think that the comments you're putting in bugzilla would make good ChangeLog comments, too.
Comment 4 Early Warning System Bot 2011-12-12 15:15:48 PST 
Comment on attachment 118856 [details]
Remove JSString vptr optimizations

Attachment 118856 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10847094
Comment 5 Gyuyoung Kim 2011-12-12 16:17:20 PST 
Comment on attachment 118856 [details]
Remove JSString vptr optimizations

Attachment 118856 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10847113
Comment 6 Gustavo Noronha (kov) 2011-12-12 20:00:36 PST 
Comment on attachment 118856 [details]
Remove JSString vptr optimizations

Attachment 118856 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10848214