Bug 73521 - [JSC] window.Option should be OptionConstructor
Summary: [JSC] window.Option should be OptionConstructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 73496 73498
  Show dependency tree / graph
 
Reported: 2011-11-30 21:31 PST by Kentaro Hara
Modified: 2011-12-01 00:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.67 KB, patch)
2011-11-30 22:19 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-11-30 21:31:29 PST 
This is a regression caused by a patch of bug 73307. If we replaced custom constructors of window.Audio and window.Option with the [NamedConstructor] IDL, fast/js/global-constructors.html, fast/dom/Window/window-properties.html and fast/dom/call-a-constructor-as-a-function.html start to fail in JSC.

Before a patch of bug 73007: (correct)
window.Audio => AudioConstructor
window.Option => OptionConstructor
window.HTMLAudioElement => HTMLAudioElementConstructor
window.HTMLOptionElement => HTMLOptionElementConstructor

After a patch of bug 73007: (wrong)
window.Audio => HTMLAudioElementConstructor
window.Option => HTMLOptionElementConstructor
window.HTMLAudioElement => HTMLAudioElementConstructor
window.HTMLOptionElement => HTMLOptionElementConstructor

We should fix it.
Comment 1 Kentaro Hara 2011-11-30 21:33:22 PST 
(In reply to comment #0)
> Before a patch of bug 73007: (correct)
> After a patch of bug 73007: (wrong)

Correction: s/bug 73007/bug 73307/
Comment 2 Kentaro Hara 2011-11-30 22:19:25 PST 
Created attachment 117340 [details]
Patch
Comment 3 WebKit Review Bot 2011-12-01 00:01:06 PST 
Comment on attachment 117340 [details]
Patch

Clearing flags on attachment: 117340

Committed r101627: <http://trac.webkit.org/changeset/101627>
Comment 4 WebKit Review Bot 2011-12-01 00:01:10 PST 
All reviewed patches have been landed.  Closing bug.