Bug 73498 - Replace a custom constructor of window.Option with the [NamedConstructor] IDL
Summary: Replace a custom constructor of window.Option with the [NamedConstructor] IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on: 73521
Blocks: 71093
  Show dependency tree / graph
 
Reported: 2011-11-30 16:37 PST by Kentaro Hara
Modified: 2011-12-01 17:04 PST (History)
5 users (show)

See Also:

Attachments
Patch (22.97 KB, patch)
2011-12-01 02:01 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-11-30 16:37:05 PST 
We can remove JSOptionConstructor.{h,cpp}. We can generate the constructor of window.Option by the [NamedConstructor] IDL.
Comment 1 Kentaro Hara 2011-12-01 02:01:16 PST 
Created attachment 117383 [details]
Patch
Comment 2 Adam Barth 2011-12-01 11:40:02 PST 
Comment on attachment 117383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117383&action=review

> LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt:-1439
> -window.Option.length [number]

Same comment as with the audio patch.
Comment 3 WebKit Review Bot 2011-12-01 17:03:55 PST 
Comment on attachment 117383 [details]
Patch

Clearing flags on attachment: 117383

Committed r101724: <http://trac.webkit.org/changeset/101724>
Comment 4 WebKit Review Bot 2011-12-01 17:04:00 PST 
All reviewed patches have been landed.  Closing bug.