RESOLVED FIXED73498
Replace a custom constructor of window.Option with the [NamedConstructor] IDL 
https://bugs.webkit.org/show_bug.cgi?id=73498
Summary Replace a custom constructor of window.Option with the [NamedConstructor] IDL
Kentaro Hara
Reported 2011-11-30 16:37:05 PST
We can remove JSOptionConstructor.{h,cpp}. We can generate the constructor of window.Option by the [NamedConstructor] IDL.
Attachments
Patch (22.97 KB, patch)
2011-12-01 02:01 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-01 02:01:16 PST
Created attachment 117383 [details] Patch
Adam Barth
Comment 2 2011-12-01 11:40:02 PST
Comment on attachment 117383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117383&action=review > LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt:-1439 > -window.Option.length [number] Same comment as with the audio patch.
WebKit Review Bot
Comment 3 2011-12-01 17:03:55 PST
Comment on attachment 117383 [details] Patch Clearing flags on attachment: 117383 Committed r101724: <http://trac.webkit.org/changeset/101724>
WebKit Review Bot
Comment 4 2011-12-01 17:04:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.