Bug 73307 - Implement the [NamedConstructor] IDL in CodeGeneratorJS.pm
Summary: Implement the [NamedConstructor] IDL in CodeGeneratorJS.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-29 04:19 PST by Kentaro Hara
Modified: 2011-11-30 21:32 PST (History)
5 users (show)

See Also:


Attachments
Patch (19.99 KB, patch)
2011-11-29 04:26 PST, Kentaro Hara
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
rebased patch for commit (20.59 KB, patch)
2011-11-30 00:23 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-11-29 04:19:54 PST
CodeGeneratorV8.pm has already implemented the [NamedConstructor] IDL. CodeGeneratorJS.pm should also implement it.

The spec: http://www.w3.org/TR/WebIDL/#NamedConstructor
Comment 1 Kentaro Hara 2011-11-29 04:26:11 PST
Created attachment 116945 [details]
Patch
Comment 2 Adam Barth 2011-11-29 09:07:39 PST
It's not 100% clear to me why the notion of a named constructor is tied up with the notion of the constructor taking a Document as an argument.  We've used CallWith=ScriptExecutionContext for that elsewhere.  That said, this seems fine if all our uses take a Document.
Comment 3 WebKit Review Bot 2011-11-30 00:09:18 PST
Comment on attachment 116945 [details]
Patch

Rejecting attachment 116945 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
11 lines).
Hunk #9 succeeded at 3558 (offset 111 lines).
Hunk #10 succeeded at 3572 (offset 111 lines).
1 out of 10 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm.rej
patching file Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp
patching file Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10697090
Comment 4 Kentaro Hara 2011-11-30 00:23:04 PST
Created attachment 117135 [details]
rebased patch for commit
Comment 5 WebKit Review Bot 2011-11-30 06:56:06 PST
Comment on attachment 117135 [details]
rebased patch for commit

Clearing flags on attachment: 117135

Committed r101508: <http://trac.webkit.org/changeset/101508>