Bug 73307 – Implement the [NamedConstructor] IDL in CodeGeneratorJS.pm

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kentaro Hara]

CodeGeneratorV8.pm has already implemented the [NamedConstructor] IDL. CodeGeneratorJS.pm should also implement it.

The spec: http://www.w3.org/TR/WebIDL/#NamedConstructor

[Kentaro Hara]

Created attachment 116945 [details]
Patch

[Adam Barth]

It's not 100% clear to me why the notion of a named constructor is tied up with the notion of the constructor taking a Document as an argument.  We've used CallWith=ScriptExecutionContext for that elsewhere.  That said, this seems fine if all our uses take a Document.

[WebKit Review Bot]

Comment on attachment 116945 [details]
Patch

Rejecting attachment 116945 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
11 lines).
Hunk #9 succeeded at 3558 (offset 111 lines).
Hunk #10 succeeded at 3572 (offset 111 lines).
1 out of 10 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorJS.pm.rej
patching file Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp
patching file Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10697090

[Kentaro Hara]

Created attachment 117135 [details]
rebased patch for commit

[WebKit Review Bot]

Comment on attachment 117135 [details]
rebased patch for commit

Clearing flags on attachment: 117135

Committed r101508: <http://trac.webkit.org/changeset/101508>