Now that more <track> pieces are in place, we can enable the WebVTT parsing tests! A few little tweeks are required: (1) create a TextTrackCueList when TextTrack's cues() is called and (2) pay attention to chronological timestamp order requirement of WebVTT files. I'll include both small changes in with the patch.
Created attachment 114835 [details] Patch
Comment on attachment 114835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114835&action=review > LayoutTests/media/track/track-webvtt-tc000-empty.html:2 > +<html> > + <head> These are tests of an HTML5 feature, so they might as well have "<!DOCTYPE html>"
Comment on attachment 114835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114835&action=review > Source/WebCore/html/TextTrackCueList.cpp:86 > void TextTrackCueList::add(PassRefPtr<TextTrackCue> cue) > { > + // WebVTT cue timings > + // 1. The time represented by this WebVTT timestamp must be greater than or equal > + // to the start time offsets of all previous cues in the file. > + // http://www.whatwg.org/specs/web-apps/current-work/#webvtt-cue-timings > + // Note: because this requirement is specific to WebVTT, we may want to check first > + // whether the cues in this list came from a WebVTT file. This needs a layout test if we don't already have one.
Comment on attachment 114835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114835&action=review >> Source/WebCore/html/TextTrackCueList.cpp:86 >> + // whether the cues in this list came from a WebVTT file. > > This needs a layout test if we don't already have one. Yes, this is the one: track-webvtt-tc012-out-of-order.html >> LayoutTests/media/track/track-webvtt-tc000-empty.html:2 >> + <head> > > These are tests of an HTML5 feature, so they might as well have "<!DOCTYPE html>" Will do, thanks.
Created attachment 114844 [details] Patch for landing
Comment on attachment 114844 [details] Patch for landing Clearing flags on attachment: 114844 Committed r100085: <http://trac.webkit.org/changeset/100085>
All reviewed patches have been landed. Closing bug.