Bug 72369 - media/track/track-webvtt-tc003-newlines.html is flaky
Summary: media/track/track-webvtt-tc003-newlines.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anna Cavender
URL:
Keywords:
Depends on:
Blocks: 72215
  Show dependency treegraph
 
Reported: 2011-11-15 02:33 PST by Tony Gentilcore
Modified: 2011-11-15 11:30 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2011-11-15 02:35 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2011-11-15 10:16 PST, Anna Cavender
no flags Details | Formatted Diff | Diff
Patch for landing (2.77 KB, patch)
2011-11-15 10:24 PST, Anna Cavender
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2011-11-15 02:33:09 PST
media/track/track-webvtt-tc003-newlines.html has been flaky since it was introduced by r100085.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-webvtt-tc003-newlines.html

I'm marking it flaky for now.
Comment 1 Tony Gentilcore 2011-11-15 02:35:20 PST
Created attachment 115131 [details]
Patch
Comment 2 Tony Gentilcore 2011-11-15 02:37:20 PST
Committed r100257: <http://trac.webkit.org/changeset/100257>
Comment 3 Anna Cavender 2011-11-15 10:16:58 PST
Created attachment 115191 [details]
Patch

change guarantees tests will run in order
Comment 4 Tony Gentilcore 2011-11-15 10:23:21 PST
Comment on attachment 115191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115191&action=review

Thanks again for jumping on this flakiness so quickly.

A couple of minor suggestions inline.

> LayoutTests/media/track/track-webvtt-tc003-newlines.html:14
> +                numberOfTracksLoaded++;

Probably best to "var numberOfTracksLoaded = 0" up on line 9 or 10.

> LayoutTests/media/track/track-webvtt-tc003-newlines.html:17
> +                    testTrack(1);

This is a bit more future proof and the same number of lines:

for (var i = 0; i < numberOfTrackTests; i++)
    testTrack(i);
Comment 5 Anna Cavender 2011-11-15 10:24:33 PST
Created attachment 115193 [details]
Patch for landing
Comment 6 WebKit Review Bot 2011-11-15 11:30:06 PST
Comment on attachment 115193 [details]
Patch for landing

Clearing flags on attachment: 115193

Committed r100299: <http://trac.webkit.org/changeset/100299>
Comment 7 WebKit Review Bot 2011-11-15 11:30:11 PST
All reviewed patches have been landed.  Closing bug.