Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
Created attachment 114414 [details]
Once this is in, hopefully we can run the test-webkitpy tests on the commit-queue again, and we can get rid of the evironment overrides in start-queue.sh which are breaking the cq for folks with unicode names. :)
Comment on attachment 114414 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=114414&action=review
> + @classmethod
> + def disable_gcc_smartquotes(self, env):
I think you want the Host to vend your a mutable Environment object that has a getter that returns the env dictionary. The MockHost can then vend you a legit Environment object with a dictionary initialized to something independent of the actual environment.
Created attachment 116438 [details]
Committed r101107: <http://trac.webkit.org/changeset/101107>
Adam: Would you try removing the envionment hack in the ews/cq servers now that this has landed?
> Adam: Would you try removing the envionment hack in the ews/cq servers now that this has landed?
Sure, although I'll probably wait until after Thanksgiving so I don't have to do any crisis management over the holiday weekend.
This got rolled out in bug 73062. Fixing now.
Committed r101266: <http://trac.webkit.org/changeset/101266>