Bug 71961 - Make the Port object have a Host
Summary: Make the Port object have a Host
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on:
Blocks: 71983
  Show dependency treegraph
Reported: 2011-11-09 15:29 PST by Eric Seidel (no email)
Modified: 2011-11-09 17:55 PST (History)
4 users (show)

See Also:

Patch (84.53 KB, patch)
2011-11-09 15:34 PST, Eric Seidel (no email)
abarth: review+
abarth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-11-09 15:29:26 PST
Make the Port object have a Host
Comment 1 Eric Seidel (no email) 2011-11-09 15:34:07 PST
Created attachment 114379 [details]
Comment 2 Adam Barth 2011-11-09 15:38:15 PST
Comment on attachment 114379 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=114379&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:90
> +                 port_name=None, options=None,

Separate lines?

> Tools/Scripts/webkitpy/layout_tests/port/factory.py:126
> +        host = host or self._host

I would have put this at the top of the function, but whatever.
Comment 3 Eric Seidel (no email) 2011-11-09 15:41:00 PST
Committed r99773: <http://trac.webkit.org/changeset/99773>